GameYob icon indicating copy to clipboard operation
GameYob copied to clipboard

Fix desync on netplay start

Open tilderain opened this issue 3 years ago • 1 comments

I noticed random inputs on netplay start when implementing GameYob's multiplayer into Cave Story DS, and this commit should fix it. Unfortunately I can't test this as I don't have two flashcarts, but I can confirm that this did fix the desync problems I was having during early multiplayer testing. There are a few more improvements I'd like to push as well (same frame delay on client and host, don't disconnect when packets aren't received, set SRAM transfer packet to require acknowledge), but I think this is ok for now.

tilderain avatar Apr 15 '22 01:04 tilderain

I don't think I want to merge this for now without it having been tested, but I'll look into it if I ever come back to this. The memsets by themselves are fine but I'm not sure about the other lines that were removed. At least, I couldn't say for sure without testing it myself.

Stewmath avatar Apr 15 '22 15:04 Stewmath