Saving and Loading Need Review

[SenseiKiwi]

I looked over the code for saving and loading. Although it handles dimension dependencies properly, the design for the loading portion needs attention. PocketManager and DDSaveHandler are tightly coupled. The goal was to leave the task of loading the packed data to DDSaveHandler and PocketManager then takes that data. Instead, function calls weave back and forth between the two classes. This also makes it impossible to determine whether a dimension should be saved immediately after being loaded, so we're forced to write all dimensions to disk to be on the safe side.

Oh, and strangely enough, if loading fails, we don't do anything! But we print out a little message if loading succeeds. <_<

[SenseiKiwi]

This error has been happening sometimes to people: http://pastebin.com/2HbhkrK7

There are no reports of it on the DD thread, but people that I play with have had this happen sometimes. Presumably after a server crash. I just want to be sure that leading with that in a better way is also on the agenda, because it's enraging to some admins.