StevenLuMT

Results 128 comments of StevenLuMT

@dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 @lordcheng10 @merlimat If you have time, please help me review it, thank you.

> You are on your way! I left a suggestion for the configuration entry. > > We must also add comprehensive tests ok,thanks for reviewed, I will add testcases for...

> You are on your way! I left a suggestion for the configuration entry. > > We must also add comprehensive tests yeah, I have added two testcase: EntryLocationIndexAsyncTest/EntryLocationIndexSyncTest @eolivelli

> I'm not sure I understand why we need to have 2 different modes here. Do both methods provide the same guarantees or not? In the case of multiple replications,...

> I still cannot see a case where flushing the entry location index (ledgerId, entryId, offset) becomes the bottleneck, compared to: > > 1. Journal > 2. Entry log flush...

> ok,I understand what you mean, let me collect the time and proportion of the three parts of flush @merlimat

fix old workflow,please see #3455 for detail