async_upnp_client icon indicating copy to clipboard operation
async_upnp_client copied to clipboard

Published 20 hours ago • verified publisher icon StevenLooman

Features and BugFixes

Open helviojunior opened this issue 10 months ago • 4 comments

New Features:

  • [X] Implemment a sample Belkin virtual smart plug to be used at Amazon Alexa
  • [X] Add new variable type - XML

BugFix:

  • [X] Add space after : in HTTP header
  • [X] Correct received XML from Amazon Alexa
  • [X] BugFix at eventable variable on server
  • [X] BugFix at action name match

helviojunior avatar Sep 26 '23 12:09 helviojunior

Adjusted.

helviojunior avatar Sep 26 '23 14:09 helviojunior

Thank you for this PR! Looks mostly good to me, just one change request and question.

StevenLooman avatar Sep 26 '23 20:09 StevenLooman

Thank you for this PR! Looks mostly good to me, just one change request and question.

Do you want that i change the XML parse of code?

helviojunior avatar Sep 26 '23 23:09 helviojunior

Do you want that i change the XML parse of code?

What would the change be? I'd rather stick to the general idea of that table: out is used to serialize the value/coerce the value to a string.

I can see things not working out properly though. Some devices might want an escaped XML-string, while others want inline XML. (Whether the first or the latter is the valid option is a different discussion. I just know there are lots of different implementations out there. 😄)

Also, there is no XML datatype in https://openconnectivity.org/upnp-specs/UPnP-arch-DeviceArchitecture-v2.0-20200417.pdf. I'd like to stick to the standard as much as possible. Perhaps you can use a string datatype and serialize/deserialize yourself? Or include a monkey patch in the specific server to fiddle in the XML datatype?

StevenLooman avatar Sep 27 '23 21:09 StevenLooman