async_upnp_client
async_upnp_client copied to clipboard
Features and BugFixes
New Features:
- [X] Implemment a sample Belkin virtual smart plug to be used at Amazon Alexa
- [X] Add new variable type - XML
BugFix:
- [X] Add space after
:
in HTTP header - [X] Correct received XML from Amazon Alexa
- [X] BugFix at eventable variable on server
- [X] BugFix at action name match
Adjusted.
Thank you for this PR! Looks mostly good to me, just one change request and question.
Thank you for this PR! Looks mostly good to me, just one change request and question.
Do you want that i change the XML parse of code?
Do you want that i change the XML parse of code?
What would the change be? I'd rather stick to the general idea of that table: out
is used to serialize the value/coerce the value to a string.
I can see things not working out properly though. Some devices might want an escaped XML-string, while others want inline XML. (Whether the first or the latter is the valid option is a different discussion. I just know there are lots of different implementations out there. 😄)
Also, there is no XML datatype in https://openconnectivity.org/upnp-specs/UPnP-arch-DeviceArchitecture-v2.0-20200417.pdf. I'd like to stick to the standard as much as possible. Perhaps you can use a string datatype and serialize/deserialize yourself? Or include a monkey patch in the specific server to fiddle in the XML datatype?