publish-jazzy-docs icon indicating copy to clipboard operation
publish-jazzy-docs copied to clipboard

No need for PAT?

Open Bouke opened this issue 4 years ago • 5 comments

I think this action can work without a PAT, just using the GITHUB_TOKEN that's already provisioned when running the workflow. I've configured this action like so:

      - name: Publish Jazzy Docs
        uses: Steven0351/[email protected]
        with:
          personal_access_token: ${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}

Anything against this? I'd rather not provide actions with a broad PAT, only something scoped to the repo it's running against.

Bouke avatar Jun 06 '20 17:06 Bouke

Performing a commit without a PAT will work, but it will not trigger a GitHub pages build which would entirely defeat the purpose of the action

Steven0351 avatar Jun 06 '20 18:06 Steven0351

Indeed not a bug, it came with the template, I should've used the blank instead.

I'm seeing my GitHub page being updated when using the GITHUB_TOKEN as shown above. The push is succeeding just fine: https://github.com/Bouke/HAP/runs/745668855?check_suite_focus=true#step:3:462. Is there anything not working in my setup that I'm not aware of?

Bouke avatar Jun 07 '20 07:06 Bouke

This discussion along with your experience does appear to ring true, though it was not the case when I originally created the action. Thanks for opening the issue and bringing it to my attention

Steven0351 avatar Jun 11 '20 03:06 Steven0351

I think that's still true, as my pages don't get published with GITHUB_TOKEN.

Bouke avatar Aug 02 '20 11:08 Bouke

It does work, as also mentioned in the thread referenced in the readme.

Bouke avatar Aug 02 '20 13:08 Bouke