WebWindow icon indicating copy to clipboard operation
WebWindow copied to clipboard

Implemented Dispose

Open ajmcateer opened this issue 6 years ago • 2 comments

I implemented dispose in the WebWindow but I am having trouble getting it to work in Windows. Linux was a complete shot in the dark as I have never worked with C++ let alone on Linux before. I get

Exception thrown: 'System.EntryPointNotFoundException' in WebWindow.dll

whenever I try to call the dispose method. As far as I can tell I implemented everything correctly, but I am knew to C++ so its very likely I missed something. Any feedback would be greatly appreciated. I also didn't see a WebWindow.Mac.cpp file to make changes too.

ajmcateer avatar Nov 22 '19 04:11 ajmcateer

I also didn't see a WebWindow.Mac.cpp file to make changes too.

It's WebWindow.Mac.mm.

Berrysoft avatar Dec 01 '19 12:12 Berrysoft

@ajmcateer Thanks for contributing this!

Do you think you'll be in a position to finish this PR off? That would involve figuring out the solution to whatever issue you're describing, as well as tidy this up to remove the unnecessary changes (e.g., in WebWindow.Native.vcxproj).

If that's not something you'll get round to, no problem - I may add some functionality like this myself eventually, though there's no ETA.

SteveSandersonMS avatar Jan 06 '20 13:01 SteveSandersonMS