generator-ko icon indicating copy to clipboard operation
generator-ko copied to clipboard

Fixing babel transpiler errors. windows environments need to normaliz…

Open nenitiko opened this issue 9 years ago • 3 comments

Tried running the generator in windows and got two different errors:

  1. babel-core was not added as a dev-dependency
  2. skipped files/folders in transpilationConfig (gulpfile.js) were not matching any files under windows due to the path separator differences between the Regex strings and the pathnames, this gives many babel transpilation errors for files in node_modules (jquery being one of the first)

I added both the babel-core npm depepdency and the normalization/conversion of backslashes to posix dir separators (by using github.com/sindresorhus/slash) before transpilation occurs.

nenitiko avatar Oct 22 '15 22:10 nenitiko

:+1: This is ace, I spent half an hour tinkering and making it work then noticed this PR - you could have saved me half an hour had I looked before tinkering haha.

carbontwelve avatar Nov 29 '15 17:11 carbontwelve

Good job in Fixing the issue! :+1:

gabriel-sas avatar Jan 19 '16 22:01 gabriel-sas

thks, just fixed the bug

jeanPokou avatar May 24 '16 15:05 jeanPokou