Steve Gilham

Results 135 comments of Steve Gilham

Here's an experimental build that attempts to identify and fix the defective constant definitions [altcover.8.3.702-github-pre.nupkg.zip](https://github.com/SteveGilham/altcover/files/9541063/altcover.8.3.702-github-pre.nupkg.zip) It will log as a warning any such constant giving its name and the method...

That's very interesting, as the type `IList` is not a primitive (integer, bool, or such), but one that does have a legitimate null value. The `MoveNext()` method is of course...

That's even simpler than I'd expected. Thank you for that.

Cecil issue 873 raised; and PR submitted. For the moment, though, I shall retain the experimental changes, awaiting a new release of that library.

[AltCover 8.3.839 release](https://www.nuget.org/packages/altcover/8.3.839#release-body-tab) contains this fix but with the messages directed to the Verbose rather than Warn output channel.

This is using SDK 6.0.401 and FSharp.Core 6.0.6 -- the absolute latest at time of writing.

Using fantomas, the tool itself indicates the code will become invalid ![Screenshot 2022-09-26 082558](https://user-images.githubusercontent.com/7460854/192217498-d186d699-6f93-4720-9033-f61353d63180.png) When forced, this is the sole difference in the file ([github at the 'before' state](https://github.com/SteveGilham/altcover/blob/3ba6c162db9c30c42d834165e33ccdfd06e8032a/AltCover.Engine/Main.fs)) ![Screenshot...

Indenting the when clause further resolves the issue ![Screenshot 2022-09-26 090349](https://user-images.githubusercontent.com/7460854/192225629-489f618a-4638-4780-b180-3ea2d932fa87.png) but then running fantomas over that code gives ![Screenshot 2022-09-26 090908](https://user-images.githubusercontent.com/7460854/192226221-143d7e1f-7dff-47ef-a1d1-57aaf17a8c6d.png) which this time gives a useful error message...

The above was with 5.0.0 installed; having upgraded to 5.0.2, ![Screenshot 2022-09-26 095508](https://user-images.githubusercontent.com/7460854/192235330-865121e8-8809-4285-a487-c2133540372c.png) nothing else changes. FWIW, configuration file used [is here](https://github.com/SteveGilham/altcover/blob/1c4e88dda86fe119b11e114b107ea9ba438c31f3/.editorconfig); the first 3 lines are the only ones...

Experimenting with `.editorconfig`, the significant factor is setting `indent_size=2`; my intuition is that the block is detected as being indented one indent size, and that is assumed sufficient not to...