Vogen icon indicating copy to clipboard operation
Vogen copied to clipboard

fix Conversions setting to allow a local overide to specify Conversion.Default when the Global value is set to somthing else

Open stocksr opened this issue 5 months ago • 1 comments

Fixes #810

Adds a new "Unspecifed" member to the Conversions Enum and uses that rather than Default Adds unit tests for the new behavour and the previously broken behavour.

I have kept the "Conversions.Default" member for backwards compatibility - as any change to that causes a huge chunk of test fails. However I think it could be removed in the next major version.

stocksr avatar Jul 09 '25 08:07 stocksr

Thanks very much for the PR - great work. I'll check back in a few hours to take a further look. Thanks again!

SteveDunn avatar Jul 17 '25 21:07 SteveDunn

Closing this as it has now been merged in PR https://github.com/SteveDunn/Vogen/pull/871 Thanks very much for the bug report and PR - much appreciated - and apologies again for the very slow response!

SteveDunn avatar Dec 19 '25 09:12 SteveDunn