PS2KeyboardHost icon indicating copy to clipboard operation
PS2KeyboardHost copied to clipboard

Possible mistake in "bool setTypematicRateAndDelay"

Open kaskalis opened this issue 9 months ago • 0 comments

Many thanks for this well-coded library.

If I understood the PS/2 keyboard protocol correctly, the number of bits that parameter "startDelay" should be left-shifted is 5 instead of 4 in line 630 of "ps2_Keyboard.h" :

bool setTypematicRateAndDelay(TypematicRate rate, TypematicStartDelay startDelay) {
    byte combined = (byte)rate | (((byte)startDelay) << 4);
    return this->sendCommand(ps2CommandCode::setTypematicRate, combined);
}

Please forgive me if I got it wrong...

kaskalis avatar May 13 '24 09:05 kaskalis