dragend icon indicating copy to clipboard operation
dragend copied to clipboard

One fix, One upgrade

Open joetex opened this issue 10 years ago • 2 comments

There was a bug with large minDragDistance values, where it would not scroll back to page if the distanceX was < 0.

This was on line 428: } else if (parsedEvent.distanceX > 0 || parsedEvent.distanceX > 0) { I fixed to: } else if (parsedEvent.distanceX > 0 || parsedEvent.distanceX < 0) {

I also needed to know which direction the onSwipeStart was moving, so I added the direction as the 4th parameter to the onSwipeStart event. This would be beneficial to onSwipeEnd as well.

joetex avatar Jan 06 '16 22:01 joetex

You should file a pull request.

m1sta avatar Feb 25 '16 18:02 m1sta

your else if fires if distanceX is less than 0 and if greater than 0 :)

the correct one is:

Math.abs(parsedEvent.distanceX) > 0 || Math.abs(parsedEvent.distanceY) > 0`

it should fire for both X and Y abs values.

Roman-Mzh avatar Jun 15 '16 12:06 Roman-Mzh