ReduxSimpleStarter icon indicating copy to clipboard operation
ReduxSimpleStarter copied to clipboard

Google maps API key error

Open TVScoundrel opened this issue 8 years ago • 2 comments

Hi @StephenGrider, Not sure if it was left in on purpose but this line https://github.com/StephenGrider/ReduxSimpleStarter/blob/master/index.html#L6 makes a red warning appear in the console about the google maps API key not being set.

I would imagine that not every application needs google maps so I would assume that line could be removed from this repo.

It is also not being used by most of the apps built in your Udemy courses.

Cheers, Tom Van Schoor

TVScoundrel avatar Dec 01 '16 13:12 TVScoundrel

Stephen:

Any reason the "" line is included in index.html from the start before it is described or needed?
As Tom mentions above, it generate a ""Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys" util.js:221:12" warning in the console log at every start.

gregt590 avatar Jul 31 '17 07:07 gregt590

Submitted a pull request for this issue https://github.com/StephenGrider/ReduxSimpleStarter/pull/167

scottwestover avatar Oct 19 '17 00:10 scottwestover