AlgoCasts icon indicating copy to clipboard operation
AlgoCasts copied to clipboard

Palindrome - some tests are passing without implementation

Open oliverhr opened this issue 7 years ago • 1 comments

palindrome/test.js

  ✓ palindrome function is defined (2ms)
  ✕ "aba" is a palindrome
  ✓ " aba" is not a palindrome
  ✓ "aba " is not a palindrome (1ms)
  ✓ "greetings" is not a palindrome
  ✕ "1000000001" a palindrome
  ✓ "Fish hsif" is not a palindrome
  ✕ "pennep" a palindrome

oliverhr avatar Dec 08 '17 11:12 oliverhr

I think this is a fair point, the tests should probably check for false rather than falsy

jennysharps avatar Mar 24 '18 16:03 jennysharps