jBox icon indicating copy to clipboard operation
jBox copied to clipboard

JQMIGRATE: jQuery.type is deprecated

Open ebwaked opened this issue 3 years ago • 4 comments

`// Set the jBox type

    jQuery.type(type) == 'string' && (this.type = type);`

jQuery.migrate-3.3.2 throws this warning for line 198 in jbox.all.js v 3.5

I am not sure how to fix this or else I would do a PR.

ebwaked avatar Feb 16 '22 22:02 ebwaked

It's just a little check that makes sure the passed type is a string and only set's it's internal type to it; if it is.

J-Brk avatar Jun 16 '22 16:06 J-Brk

https://github.com/StephanWagner/jBox/blob/4f64562baef7502a03002076711640b4218301b6/dist/jBox.js#L198

J-Brk avatar Jun 16 '22 16:06 J-Brk

@J-Brk i would have thought that would have worked. I made the change in my file but instead of using jbox.all.min.js I used jBox.js with the new change but got this error.

image

ebwaked avatar Jun 16 '22 19:06 ebwaked

Just commented on the pull request: You have to make the changes in the src files (src/js/jBox.js) and then build the dist files with npm install && npm run build from the root folder.

StephanWagner avatar Jun 20 '22 07:06 StephanWagner