Stephan Schroevers

Optimize `Scannable#name()` and related logic

4

Performance is improved in two ways: - By invoking `Scannable#stepName()` only when `Attr.NAME` is not explicitly set. - By optimizing `Traces#extractOperatorAssemblyInformationParts`, to which several `Scannable#stepName()` implementations delegate. The `Scannable#name()` logic...

`MemberName` checks class names too

4

As of 43ed6f3b9de2b6cb4d93488792287a945eeb5a1d, the `MemberName` check also flags type names. Resolving such violations is often much more involved than renaming (private) field names, possibly even prohibitive due to compatibility requirements....

Optimize VisitorState#getConstantExpression

4

By avoiding a second pass over the string.

If one passes multiple Java versions to `actions/setup-java`'s `java-version` property, then `~/.m2/toolchains.xml` is configured to reference all these versions. However, when `s4u/setup-maven-action` is used, only the Java version listed first...

Have `-XepPatchChecks:` skip disabled checks

1

Resolves #4943.

Enable/disable patterns by category

5

With Error Prone 2.0.15 and `-XepAllDisabledChecksAsWarnings`, the Android-specific `StaticOrDefaultInterfaceMethod` bug pattern is enabled. For a non-Android code base one can of course easily disable the pattern again with `-Xep:StaticOrDefaultInterfaceMethod:OFF`. But...

Avoid ambiguous imports with `@UseImportPolicy(STATIC_IMPORT_ALWAYS)`

6

These changes prevent Refaster rules from introducing a static import that conflicts with an existing static import. Without these changes the new test case fails with the following error: ```...

### New feature, improvement proposal We have a large multi-module build with quite a number of built-in and [extra](https://github.com/mojohaus/extra-enforcer-rules) enforcer rules enabled. For modules with many dependencies, plugin execution takes...