Allow dimming of DSO hints and labels

[gzotti]

Description

When using proportional hints or DSO vector outlines, or also when just using many DSO, they appear too bright on screen. This branch allows to reduce displayed brightness of hints (icons) and labels using two new spinboxes next to the DSO hint/label sliders.

Also, given that I simply want more modern UX where settings can be adjusted individually, I allow immediate-storing of more DSO-related fine-tune view settings. (These are still behind the power user tweak flag, config.ini:gui/immediate_save_details.)

Fixes # (issue)

Screenshots (if appropriate):

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)
• [x] This change requires a documentation update
• [ ] Housekeeping

How Has This Been Tested?

Test Configuration:

• Operating system: Win10
• Graphics Card: Geforce, but irrelevant.

Checklist:

• [x] My code follows the code style of this project.
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation (header file)
• [ ] I have updated the respective chapter in the Stellarium User Guide --- NOT YET!
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[github-actions[bot]]

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

• [ ] Are possibly unused includes removed?

Files matching guide/**:

• [ ] Did you remember to update screenshots to match new updates?
• [ ] Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

[alex-w]

(Linux) 2K resolution:

(Linux) 4K resolution:

[gzotti]

Compare globular cluster diameters (infostring) with AngleMeasure result, and switch on DSS. In master the symbol is massively too large. It's less clear with galaxies, and debatable for some diffuse nebulae. These here are with current adjusted scaling on a non-HiDPI screen.

[gzotti]

Yes, I have seen the warnings. Will fix that on weekend.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[alex-w]

@gzotti please fix compilation for msvc2017

C:\stellarium\src\core\modules\Nebula.cpp(1191): error C2679: binary '>>': no operator found which takes a right-hand operand of type 'Nebula::NebulaType' (or there is no acceptable conversion) [c:\stellarium\build-5.12-msvc2017_64\src\stelMain.vcxproj]

[gzotti]

Ah, this kludge was for MSVC2017, sorry.

[github-actions[bot]]

Hello @gzotti!

Thank you for the suggested improvement.

[github-actions[bot]]

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions[bot]]

Hello @gzotti!

Please check the latest stable version of Stellarium: https://github.com/Stellarium/stellarium/releases/latest