stellarium icon indicating copy to clipboard operation
stellarium copied to clipboard

5 sec-Annular solar Eclipse 1966-05-20: Sky too dark

Open MrRG2024 opened this issue 10 months ago • 22 comments

Hello,

I find a bug:

  • stellarium 24.1 -> Astronomical.calculations -> All Solar Eclipses -> year 1966 -> table of solar eclipses -> click 1966-05-20 to go to greatest eclipse point ->> sky is darker then by an total eclipse

best regards Ralf

MrRG2024 avatar Apr 20 '24 14:04 MrRG2024

Please attach screenshots for annular and total eclipses

alex-w avatar Apr 20 '24 15:04 alex-w

it's only for 1sec very dark and several seconds dark. Time must be stopped. eclipse_1966_t_a

MrRG2024 avatar Apr 20 '24 17:04 MrRG2024

Strange: diameter moon:sun is 0.999, but eclipse magnitude=1.000, which allows such darkness. It would be interesting to see actual footage of such an almost-total annular.

gzotti avatar Apr 23 '24 08:04 gzotti

Hello @MrRG2024!

OK, developers can reproduce the issue. Thanks for the report!

github-actions[bot] avatar Apr 23 '24 08:04 github-actions[bot]

Strange: diameter moon:sun is 0.999, but eclipse magnitude=1.000, which allows such darkness. It would be interesting to see actual footage of such an almost-total annular.

These two values are not the same because they use different method for calculations. Stellarium's solar radius (695,700 km) is smaller than solar radius in traditional eclipse calculations (696,000 km). We should use the same value, but it may not enough to fix the main issue.

worachate001 avatar Apr 24 '24 07:04 worachate001

Good point. What is the source of "our" solar radius @alex-w @xalioth ? Changing that to 696000 (still used in the 2013 Supplement) creates a razor-sharp annular eclipse (again with magnitude 1.000 (looks to be correctly rounded) /obscuration 99.91%. I can also see strange artifacts in ShowMySky on the best spot within a few seconds of annularity when the Lunar shadow races through the zenith, (@10110111 Mode 3 only, no big deal, though.)

And I should probably add another brightness tweak to reduce earthshine during annular solar eclipses. EDIT: Done in https://github.com/Stellarium/stellarium/commit/375f3450a1721e0b17d6007bcd073cd32f634538

gzotti avatar Apr 24 '24 20:04 gzotti

Mode 3 only, no big deal, though

Mode 3 should be the best in quality. If it suffers from a problem that doesn't exist in lower levels, it's bad.

From my side, I can't even reproduce the dark scene as described by the OP.

10110111 avatar Apr 24 '24 20:04 10110111

stellarium-104

This ring is visible over 3 seconds or so.

It may be somewhat too dark in 1966, although this is really a border case. Must have looked like circumferential Baileys Beads seconds from totality. (Are there photos of this one? EDIT: YES! http://xjubier.free.fr/en/site_pages/solar_eclipses/ASE_19660520_pg01.html

Another interesting study is https://books.googleusercontent.com/books/content?req=AKW5QaevTc-nNaVSLdrU1AJxQzsO2dH61dCU6tEF2hYFIpKpOhxhq9-Mq6z0L2cQnYBKXpfgxTgsVT9Czt_ZghIFFAmSM3X87THB1ZnQ0gs113X-6LbhFzyb9UpdDR6prldG2lw4aa6m-7zx-rkzbBpGRbLCPRQok_sZT7LLldia9bsxiskmhhiq4SwyYFhEEuuT6uB-t39e-c0qgHgXrtCLee70jj40JEOp8T8zSyY-5ZkGae217wMV0WSLDeANABvQLZ7UV2SR0SSXITZC83pytc_xCI9PgQ) For a wider annular eclipse like 2005, sky brightness seems OK. It "is" slightly dark like minutes before a totality.

gzotti avatar Apr 24 '24 21:04 gzotti

We have #define SUN_RADIUS 696000. in StelUtils.hpp file, but we have other value in ssystem_major.ini file. I've changed radius value in the ini file, and probably this issue has been added by me, when I updated properties of Solar system bodies from IAU and NASA handbooks.

alex-w avatar Apr 25 '24 03:04 alex-w

@gzotti @worachate001 please check the master

alex-w avatar Apr 25 '24 03:04 alex-w

Thanks @alex-w. I would like to note that I couldn't reproduce the very dark sky posted by @MrRG2024. The sky during annularity seems a bit too dark, but not very dark like that. It might be related to GPU or graphic mode?

worachate001 avatar Apr 25 '24 04:04 worachate001

stellarium-104

This ring is visible over 3 seconds or so.

Do you use the default textures, those contained in the default installation? I've found that using higher resolution textures solves many otherwise visible artifacts.

Atque avatar Apr 25 '24 05:04 Atque

Here are all near total eclipses from 1960-2040 as a panel. Plus 2 just so total ones. 1967-11-02 totally without duration 1986-10-03 Hybrid with duration 0 seconds (Before I saw that all you had to do was click on the eclipse in the table, I had manually set the location of the greatest eclipse in most of them.) near_total_1960-2040

MrRG2024 avatar Apr 25 '24 06:04 MrRG2024

@worachate001: you must stop the running time It's only for the 1 second so dark

MrRG2024 avatar Apr 25 '24 07:04 MrRG2024

This ring is visible over 3 seconds or so.

Do you use the default textures, those contained in the default installation? I've found that using higher resolution textures solves many otherwise visible artifacts.

Yes, and with flag_atmosphere_dynamic_resolution = true and atmosphere_resolution_reduction = 4. I'd still like to know more about the model to be described in the User Guide before playing with parameters again.

gzotti avatar Apr 25 '24 07:04 gzotti

Your 1966-05-20 looks like atmosphere is switched off entirely. If not, it's really a bug. For the others, this looks like the classical Preetham skylight, so the ring-like artifact I mentioned above is another issue.

gzotti avatar Apr 25 '24 07:04 gzotti

with and without atmosphere: 19660520_with-without-atmosphere

MrRG2024 avatar Apr 25 '24 08:04 MrRG2024

+-1 second: 19660520_+-1sec

MrRG2024 avatar Apr 25 '24 08:04 MrRG2024

Do you have "Dynamic eye adaption" switched off? This might explain the too many stars. I cannot reproduce the amount of darkness either, but this may indeed lie in sub-second time differences. Ah yes, now I could. Go back 10s, then play real-time. Preetham model is too dark, stars flare up for a moment. ShowMySky is much better.

--> The solution for me is "use the more modern sky model, it models solar eclipse brightness much better than the old model".

gzotti avatar Apr 25 '24 08:04 gzotti

Hello @MrRG2024!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

alex-w avatar Jun 04 '24 18:06 alex-w

Not sure if there is progress.

  • Nobody is assigned
  • The Preetham sky has this darkness problem in exceptional cases.
  • The ShowMySky is better and would be the obvious recommendation, but has this strange ring visible over a few seconds as the shadow axis sweeps over the observer. @10110111 did you follow into this?

gzotti avatar Jun 05 '24 20:06 gzotti

@10110111 did you follow into this?

No, haven't found time for this yet.


Update: this is now fixed (#3729).

10110111 avatar Jun 05 '24 21:06 10110111

I think we can declare this solved.

gzotti avatar Sep 08 '24 13:09 gzotti

Hello @MrRG2024!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions[bot] avatar Sep 08 '24 15:09 github-actions[bot]

Hello @MrRG2024!

Please check the latest stable version of Stellarium: https://github.com/Stellarium/stellarium/releases/latest

github-actions[bot] avatar Sep 22 '24 14:09 github-actions[bot]