stellarium icon indicating copy to clipboard operation
stellarium copied to clipboard

Add ability to use XML and JSON based OMM elements.

Open A-j-K opened this issue 1 year ago • 5 comments

This is a work-in-progress PR

Description

  1. [x] Update old 2008 SGP4 library to the latest 2020 version
  2. [x] Add OMM object
  3. [x] Add XML OMM reader
  4. [x] Add JSON OMM reader
  5. [ ] Extend existing TLE to allow for XML-based OMM

Fixes #2458

Type of change

  • [n/a] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [n/a] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Unit tests will be added to cover some existing code and all new code.

Checklist:

  • [ ] My code follows the code style of this project.
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation (header file)
  • [ ] I have updated the respective chapter in the Stellarium User Guide
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

A-j-K avatar Jul 08 '23 22:07 A-j-K

@alex-w CodeFactor failed on imported SGP4 libs. How is this handled? I'm not keen on editing imported code. Can exceptions be added?

A-j-K avatar Jul 08 '23 23:07 A-j-K

@alex-w CodeFactor failed on imported SGP4 libs. How is this handled? I'm not keen on editing imported code. Can exceptions be added?

See the log - it’s not critical

alex-w avatar Jul 09 '23 12:07 alex-w

Looks like good progress! For a cleaner history, it's better to occasionally rebase from master, not merge master into your work. This should be very easy if you are editing just a plugin while nobody else interferes. Codefactor warns about cleaning up empty lines. Please adhere to these. For the "complex method" warnings, if there is no way to reduce complexity, we must accept that.

gzotti avatar Jul 09 '23 17:07 gzotti

Any news?

alex-w avatar Oct 18 '23 02:10 alex-w

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 05 '23 07:12 github-actions[bot]