Cannot create a subfolder for screenshot from a script

[janbilek]

Expected Behaviour

When setting a screenshot path it has to exist core.screenshot("fileName", false, "my/new/folder", true);

Actual Behaviour

Stellarium complaints in a console about missing destination folder Error: cannot create screenshot directory: Could not create directory: INFO Saving screenshot in file: "/home/blech/Pictures/Stellarium/stellarium-002.png"

Steps to reproduce

Use following code in a script: core.screenshot("fileName", false, "my/new/folder", true);

System

• Stellarium version: 7ebcf893ff5eaa90336e5587ec0df1a0af2a1166
• Operating system: Linux
• Graphics Card: Irrelevant
• Screen type (if applicable): Irrelevant

Logfile

N/A

[janbilek]

I have a fix proposal here already. Please do nothing about this.

[github-actions[bot]]

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

[gzotti]

I think we had discussed this, and decided to not allow creation of new directories for safety reasons. @alex-w ?

[janbilek]

Howdy @gzotti & @alex-w - all good & no worries, it was a dinner time here in Brisi and I had some problems with github authentication, but when you'll see it - I am changing practically nothing, clearly not adding nothing new. Please give me another 2 hrs to put kids in bed.

[janbilek]

Howdy again, I am back but it doesn't allow me to post a fix + script - even using a separate branch. I am sorry, but I have no experience with public repositories like this. Would you please provide me with any guidance? I am going to send a patch through the mailing list meanwhile.

[alex-w]

@janbilek sorry, I didn't check the patch, but... are you fixed error message?

[alex-w]

I think we had discussed this, and decided to not allow creation of new directories for safety reasons. @alex-w ?

Yes, but I didn’t check saving screenshots into subdirectories.

[alex-w]

OK, I've checked the patch and: a) the fix is not completed yet and it potentially dangerous b) we does not allow creation of new directories via scripts

Of course we may implement this feature request, but in this case we should add many checks for various platforms by safety and security reasons.

[gzotti]

We could allow it, but only guarded by a user-defined decision (extra boolean non-property FileMgr::flagAllowScreenshotExtraDir or so) which must by default be off. This flag should not be settable by a script!

[github-actions[bot]]

Hello @janbilek!

Thank you for suggesting this feature.

[gzotti]

Note that STORING to some existing directory is already possible. See the skybox.ssc for example. Not sure if really creation of arbitrary directories is good.

[janbilek]

Thank you @alex-w & @gzotti for dedicating your time to this. So I hope that it is clear why I needed the creation of arbitrary directories. Honestly I think that all this is more like a one-off use case for our project and you should probably keep that conservative side as it proven doing very well so far.

There is an obvious workaround to have those output folders pre-prepared - which fixes it all.

Of course, I'll be honored to be able to contribute a line or two to your project. So if there is any further work on this needed, I'm happy to follow whatever guidance from your side. On other hand I am also old enough to admit that you guys know the best. :)