stellarium icon indicating copy to clipboard operation
stellarium copied to clipboard

Added support public version of Stellarium

Open alex-w opened this issue 1 year ago • 4 comments

Description

This pull request introduces splitting version number of Stellarium onto 2 partially independent versions - "inner version" (i.e., 0.22.3) and "public version" (i.e., 22.3) of Stellarium. This solution avoiding troubles for releasing two series of Stellarium in same time - series 0.x for releases, based on Qt5 and series 1.x for releases, based on Qt6. Plus 2 digits for version numbering of the planetarium are used already by many regular users.

As extra feature I've added 2 extra lines into About dialog - "Version..." and "Based on Qt...". The first one contains inner version of the planetarium and the second one contain version of Qt which was used for building the Stellarium. The second extra feature - refactored displaying version number on the splash screen.

The new feature is backward compatible and probably should be merged into master after 1.0 release.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change requires a documentation update

Checklist:

  • [x] My code follows the code style of this project.
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (header file)
  • [ ] I have updated the respective chapter in the Stellarium User Guide
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

alex-w avatar Aug 02 '22 14:08 alex-w

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • [x] Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

github-actions[bot] avatar Aug 02 '22 14:08 github-actions[bot]

@gzotti should we merge it before next release to make version 1.0 as first public version?

alex-w avatar Aug 05 '22 10:08 alex-w

I hope we can release 1.0 instead of 0.22.3. Not sure how "1.0" will appear in this PR. Or we simply call the next release already 22.3, but (manually) paint a big 1.0 on the splash screen and the User Guide's cover, just for this release, which will have 0.22.3 (Win 32bit, Ubuntu 18/20) and 1.22.3 (Win64, Mac, Ubuntu 22) builds... If there is any blocker, we must keep the release at 0.22.3, though. Maybe I should therefore have the Scripts fixed first. I just fix a few more deprecated pieces, then continue there. So it may be better to wait until after the Script issue is done, early next week or so (hopefully).

gzotti avatar Aug 05 '22 11:08 gzotti

OK, I think we can postpone question about version number to the September.

alex-w avatar Aug 05 '22 11:08 alex-w

I am quite sure we can give what would have been publicly expected to be 0.22.3 finally the symbolic "1.0" label. I think all Qt6 troubles have been solved? Scripting, Audio/Video players work again (PR merge pending). I still don't know how to best bring the "1.0" into the limelight. Maybe a special splash screen for this release? Else IMHO this can now be merged to prepare for the equinox release. @xalioth ?

gzotti avatar Aug 19 '22 12:08 gzotti

I've added big numbers for splash screen for releases ;)

alex-w avatar Aug 19 '22 14:08 alex-w

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions[bot] avatar Sep 04 '22 11:09 github-actions[bot]

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions[bot] avatar Sep 10 '22 07:09 github-actions[bot]

Hello @alex-w!

Please check the latest stable version of Stellarium: https://github.com/Stellarium/stellarium/releases/latest

github-actions[bot] avatar Oct 01 '22 12:10 github-actions[bot]