stellarium icon indicating copy to clipboard operation
stellarium copied to clipboard

Observing list seems to think everything is a nebula

Open ckuethe opened this issue 2 years ago • 5 comments

Expected Behaviour

Observing list correctly displays object type, eg. nebula, star, galaxy, globular cluster, ...

Actual Behaviour

Observing list shows all objects as nebulas Screenshot_2022-05-31_19-30-54

Steps to reproduce

Created a list, added some objects that aren't nebulae

System

  • Stellarium version: Stellarium-0.22.1-x86_64.AppImage
  • Operating system: Xubuntu 22.04
  • Graphics Card: Intel TigerLake-LP GT2 [Iris Xe Graphics], Mesa Intel(R) Xe Graphics (TGL GT2) (0x9a49), 4.6 (Core Profile) Mesa 22.0.1
  • Screen type (if applicable): 1920x1080, 96dpi, 24bpp

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.

ckuethe avatar Jun 01 '22 02:06 ckuethe

Hi @ckuethe and thank you for this message. Actually it is not directly a problem with ObservingList because the object type returned by Stellarium for Abell 2151, for example, is Nebula.

@alex-w @gzotti is it normal ?

nebula

Jocelyn

Jocelyn1109 avatar Jun 01 '22 11:06 Jocelyn1109

Hi @ckuethe and thank you for this message. Actually it is not directly a problem with OObservingList because the object type returned by Stellarium for Abell 2151, for example, is Nebula.

@alex-w @gzotti is it normal ?

Yes, it is normal currently. I’ll add special method for getting the correct object type tomorrow (this feature in TODO list)

alex-w avatar Jun 01 '22 12:06 alex-w

@alex-w ok perfect thanks ;)

Jocelyn1109 avatar Jun 01 '22 12:06 Jocelyn1109

The new method getObjectType() return object's type. It should be English lowercase name of the type of the object (as a type string in infobox).

Typical usage: QString objType = selectedObject[0]->getObjectType();

The method getType(); return the name of object' class by the fact.

P.S. @Jocelyn1109 you need to save the both types (getType() & getObjectType()) into JSON file. The first one should be used in methods findAndSelect and searchByName to search an object by his type within his class (see #1884). Obviously data from getObjectType should be visible for users and data from getType should be invisible for users. The new method should resolve issue #2440 also.

alex-w avatar Jun 02 '22 09:06 alex-w

Hi @alex-w, as you can see on the picture everything is working properly with your new method getObjectType(). I did the test with Sun, Vesta (asteroid) and all other items in this ticket that appeared as Nebula (see first post).

Jocelyn

object-type

Jocelyn1109 avatar Jun 02 '22 10:06 Jocelyn1109

Hello @ckuethe!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions[bot] avatar Sep 22 '22 17:09 github-actions[bot]

So a small nit - the observing list needs to be recreated or objects need to be re-added to an existing list pick up the new object type, but aside from that it works.

Screenshot_2022-09-22_12-08-51

ckuethe avatar Sep 22 '22 19:09 ckuethe

@ckuethe you can create a new list and import the old into it

Jocelyn1109 avatar Sep 22 '22 19:09 Jocelyn1109

@ckuethe I will give you more details tomorow morning when I will be in front of my computer 😀

Jocelyn1109 avatar Sep 22 '22 19:09 Jocelyn1109

No worries, I got my observing list the way I wanted it. I'm just point out that my old list didn't just magically upgrade the object type. Once I recreated it, the object types were all correct.

ckuethe avatar Sep 22 '22 19:09 ckuethe

Hi @ckuethe , Here is the information regarding the import of old lists in the "observing lists":

  • when switching to the new version of Stellarium with "observing lists" the legacy bookmarks.json will be automatically imported into the observation lists with the name "bookmarks list",
  • if you want to import another "observing list" the best way is to create a new list and to import it into it.
  • if you want to import another "bookmarks.json" do the same.

These features have been tested by me (the developer) and should work, but they still need further testing. Do not hesitate to come back to me for any questions or problems.

Jocelyn

Jocelyn1109 avatar Sep 23 '22 07:09 Jocelyn1109

Hello @ckuethe!

Please check the latest stable version of Stellarium: https://github.com/Stellarium/stellarium/releases/latest

github-actions[bot] avatar Oct 01 '22 12:10 github-actions[bot]