PoeFilterX icon indicating copy to clipboard operation
PoeFilterX copied to clipboard

Feature Discussion - Better Injection of Variables

Open SteffenBlake opened this issue 3 years ago • 0 comments

So after personal testing I have found that relying primarily on injection of variables via Environment Vars to be... very lackluster.

Specifically, Enviro Vars have a maximum length that can be supported and a lot of stuff can potentially break when you try and store very very VERY big enviro vars on windows.

So, to that end, I'd be curious to hear folks thoughts on what might be a better way to store variable data for injection into one's filters.

For reference on what this is discussing: https://github.com/SteffenBlake/PoeFilterX/wiki/Code-Guide#variable-injection

So at the moment you could create the variable with the name POEFILTERX_ChaosTierCurrency and store a bunch of Currency basetypes in it. This string length can get very big very fast though.

Then you could make a filterblock like:

HasValue %ChaosTierCurrency%;
BaseType %ChaosTierCurrency%;
Style chaos-tier currency;

(Reminder on how HasValue works: https://github.com/SteffenBlake/PoeFilterX/wiki/FilterX-Conditions#hasvalue)

So the above will then check if you have injected ChaosTierCurrency and if so, it will make the block that matches any of the base types in that variable, and apply the styles of chaos-tier and currency to it.

So effectively speaking these variables need to be handled in some way that is a Dictionary of String to List of Strings, or, String to String (my logic already can handle parsing 1 large space delimited string of values no problem)

Thoughts on how to approach this? Do we perhaps just want to utilize a Sqlite database locally? Or a text file?

I'd like to hear folks on what would be easiest for them to parse.

SteffenBlake avatar Dec 13 '22 07:12 SteffenBlake