BusinessCentral.LinterCop icon indicating copy to clipboard operation
BusinessCentral.LinterCop copied to clipboard

LinterCop.json Spelling issues

Open tscottjendev opened this issue 2 years ago • 1 comments

There are a couple of spelling mistakes in the entries for the LinterCop.json

{
    "cyclomaticComplexetyThreshold": 6,
    "maintainablityIndexThreshold": 55,
    "enableRule0011ForTableFields": true
}

cyclomaticComplexetyThreshold should be cyclomaticComplexityThreshold and maintainablityIndexThreshold should be maintainabilityIndexThreshold

Can you change these without breaking changes? Can you introduce a schema for the file like there is for app.json or launch.json? In the schema can you deprecate entries?

tscottjendev avatar Sep 21 '22 10:09 tscottjendev

I do not know how to provide a schema for this file. Would need to check.

I probably need to support both, the current spelling and the correct one, for a period of time to not break everyone

StefanMaron avatar Oct 07 '22 07:10 StefanMaron

As I rather have this changed sooner than later, I gave it a shot to fix this in a couple of pull requests.

  • for the VSCode extension, with a json schema (with misspelled properties marked as deprecated)
  • in this repo, with support for both new and old, misspelled, properties

What do you think @StefanMaron?

jwikman avatar Jan 06 '23 21:01 jwikman