StefanKock
StefanKock
> 1. Obsolete? `de.symeda.sormas.ui.utils.DateFilter` > * DateHelper.findDateBounds > * DateHelper.findDatePrefix Opinion by @MartinWahnschaffe: Remove not used code. > 2. Relevance? `de.symeda.sormas.ui.EditFormLayoutCharting` Opinion by @MartinWahnschaffe: Keep class, remove joda-time usage.
> I think having it return null instead of new is favorable, so we will have to add explicit checks to those failing usages, which will cause some work. I...
Marked as draft to make sure merge conflicts are taken care off properly and that the change history will be kept when merging.
Refinement needed by @MartinWahnschaffe and @MateStrysewske concerning what should be shown and how updated.
Objection in the refinement: Running the similarity search several times might be more costly than running it over the cross join of all references. We should do measurements of the...
Handover with @BarnaBartha: Latest commit 2a42c5e6b00a3b6ae189b2aa74b0dbe50763fd8c is WIP and not compiling due to API changes in `CriteriaBuilderHelper`. I will continue there
> Looks like security is not a topic here. Usage of literal is internally still creating a parameter in the SQL query, as explained here: https://vladmihalcea.com/how-does-hibernate-handle-jpa-criteria-api-literals/ The current approach is...
I confirmed with @MartinWahnschaffe that just toggling to BIND mode fulfills what we wanted to achieve in this ticket.
While implementing this ticket we noticed that the approach to bind parameters was mostly already done, but could be configured with Hibernate more strict (84fc827). In consequence the parameter binding...
One collateral finding on test-de from now: ```bash Caused by: javax.ejb.TransactionRolledbackLocalException: Exception thrown from bean: java.lang.IllegalArgumentException: Parameter value [251119] did not match expected type [de.symeda.sormas.backend.caze.Case (n/a)] at com.sun.ejb.containers.EJBContainerTransactionManager.checkExceptionClientTx(EJBContainerTransactionManager.java:615) at com.sun.ejb.containers.EJBContainerTransactionManager.postInvokeTx(EJBContainerTransactionManager.java:485)...