A few issues that I noticed

[darrenaddy]

I've been learning Hugo for a few months now, which certainly doesn't make me an expert - so if any of these things is due to MY misunderstanding, please feel free to correct me. (That's how I learn.) I would really like to thank the creator of this theme, because it does a great job of making many things clear, with good commenting in the config.yaml and other files. I hope that this theme can continue to be maintained, as I've looked at a LOT of Hugo themes and this one does so many things well. Onto my "issues":

1. I believe the installation instructions should include copying the exampleSite/content folder over to the root Hugo project folder (overwriting the empty one provided with hugo new site freshsite (for example).

2. Looking at themes/layouts/_default/single.html looks a lot like baseof.html. It shouldn't. The template baseof.html is used by both single.html and list.html (in addition to the Homepage) so none of the code of baseof.html should be found in any of those files.

3. In trying to implement the sidebar, I was getting both it and the Back To Top Button doubled in the resulting source code of the built site. This is because it is found in all three of the following files: themes/layouts/index.html (the homepage), themes/layouts/_default/baseof.html (the master template of ALL other pages), and themes/layouts/_default/single.html

It seems to me that single.html should look like this (instead of doubling up the code found in baseof.html)

{{ block "main" . }}`

    {{ partial "single/single.html" . }}

    {{ if .Params.include_footer }}
    {{ partial "footer.html" . }}
  {{ end }}

4. I'm somewhat surprised that this theme contains no list templates (especially since it does contain a content/blog/posts/ (in the exampleSite). It seems to me that it would be helpful and instructive to have a _index.html in content/blog/ that lists a short summary or introductory paragraph with links to the full posts. (Perhaps this is left as an "exercise for the reader"?) :)

5. The only single.html type page in the theme is the the exampleSite/content/agb.md which (I believe) is included to show examples of using the shortcodes. In it's front matter is the "include_footer" page parameter. I would like to suggest that this theme could make use of at least a couple archetype files (to be included in the exampleSite). One could be used to create pages like the agb.md file (showing how the "include_footer" page parameter can automatically be put in the pages found in the root of the content folder (saving a little typing). And I think it would be good to show a nested archetype file for the posts made in content/blog/posts/

6. I'm not sure if I am misunderstanding how the navigation is supposed to work or if it is malfunctioning. It was my impression (from the docs) that the sidebar hamburger menu would be hidden on desktops but show on small mobile screens. I see it on the desktop and on my iPhone. I do see that the main navigation gets turned into a hamburger menu, so perhaps I should just turn OFF the sidebar. I like the effect of the sidebar menu and think it would be good to have the option to use that for mobile navigation ONLY (and have the hamburger menu created by the main navbar to be hidden or turned off for mobile. The result would be just ONE hamburger menu (of the developer's choice) rather than the two I see on mobile now.

7. Finally, a request: I have a button after the main navigation (on desktop) and at the bottom of the sidebar (for mobile). In both cases I would like that button to display a phone number AND have an href="tel:18005551212". Putting that value into the config.yaml for the link to the button does not seem to work as expected. If anyone has any suggestions for accomplishing that, I would appreciate it!

Thanks again for this great theme!

[workdojos]

Thanks again for this great theme!

@darrendaady, really great write up there! How are you getting along these days with it?

[StefMa]

Thanks for the report 🚀 Point 2 & 3 are solved via https://github.com/StefMa/hugo-fresh/pull/167 I will tackle Point 5 via https://github.com/StefMa/hugo-fresh/issues/168 Point 4 will be tackled via https://github.com/StefMa/hugo-fresh/issues/103

So only Point 1
Point 6 Point 7 are left.

Haven't thought about it yet. But I might get back to this...