harper_zed icon indicating copy to clipboard operation
harper_zed copied to clipboard

Code action to add words?

Open failable opened this issue 10 months ago • 2 comments

From this page:

This dictionary is a simple line-separated word list in plain-text. You can add and remove words at will. Code actions on misspelled words allow you to add elements to this list.

It would be nice to have LSP code action implementation in the extension to add words.

failable avatar Jan 22 '25 08:01 failable

Likewise this is a helpful feature of the Zed Codebook LSP.

jryio avatar Feb 23 '25 15:02 jryio

Looking at my language server logs in Zed

Server initialized!
stderr: 2025-02-24T18:24:06.261488Z ERROR harper_ls::backend: Settings must contain a "harper-ls" key.

~It appears that the Zed extension does not expose the ability to pass configuration directly to the harper-ls binary.~

It appears this was already addressed an implemented in #6. While the settings are passed correctly, I am not able to get the code actions to appear for adding words to either user/file dictionaries. I took a review of the harper-ls source code and the only blocker may be that the harper-ls binary installed via the Zed extension cannot find the default directory paths and/or the defined onces.

jryio avatar Feb 25 '25 01:02 jryio