Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Review in-source issue suppressions

Open bart-vmware opened this issue 3 years ago • 0 comments

After all Sonar rule issues have been addressed, activate S1309: Track uses of in-source issue suppressions temporarily by setting severity to Warning in Steeltoe.Debug.ruleset and rebuild src/Steeltoe.All.sln to make them appear in the Output window.

Alternatively, do a solution-wide search on #pragma warning to find suppressions.

Review each suppression:

  • Is the suppression still needed with the current ruleset? (tip: Resharper grays out unneeded suppressions)
  • Is the suppression justifiable, can you make it go away with limited effort?
  • If there's no justification comment, is it obvious why the suppression exists?
    • If not, track down who added the suppression, ask for clarification and add a justification comment

bart-vmware avatar Jul 28 '22 10:07 bart-vmware