Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Reuse polly

Open VenkateshSrini opened this issue 5 years ago • 3 comments

Hi Team, Is there a way where SteelToe can leverage the complete set of Polly capability. This library is far matured. What I would suggest is a capability to create a wrapper for this project which will allow it to work easily with CF. Polly is a very battle tested old library in .NET. During Lift and shift we see this library used extensively. So this will reduce the migration effort for us.

VenkateshSrini avatar Mar 26 '19 03:03 VenkateshSrini

Hi @VenkateshSrini,

I'm not clear on what exactly you're looking for. Polly should work out of the box on CF as it is not platform dependent, and I'm also not clear on what you would like Steeltoe to do with Polly. Could you please be a bit more specific about what you're looking for?

TimHess avatar Apr 11 '19 15:04 TimHess

Hi TimHess, The following is my suggestion SteelToe has Hysterix for logging the faults and also circuit breaker for handling the failure grace fully and resuming after the target service is resumed. However polly has lots of other components like wait and re-try , advanced circuit breaker and custom policies also. Now Cloud foundry standpoint, we cannot work without steeltoe as it adds various other capabilities along with this.

Now the ask is, for the resiliency portion (Circuit breaker, and other options) can we make steeltoe an wrapper over the polly project. The reason being that, we need not re-code these in steeltoe and quickly leverage the capability of so many resiliency capability of Polly. Also SteelToe will be a sort integration between Polly and Cloud foundry platform. Polly does not have Hysterix logging capability that steel toe can provide. Also during migration when we try to replace all the old environment reading code with SteelToe, if we use polly, then the resilency portion of code will be easy to migrate as SteelToe will any way consume the already used polly project library.

This is just a suggestion

VenkateshSrini avatar Apr 12 '19 03:04 VenkateshSrini

Related to #280

jkonicki avatar Apr 07 '20 19:04 jkonicki

I don't think Steeltoe is going to be providing an abstraction over Polly, especially now that we've put Hystrix into maintenance mode. A metrics implementation for Polly would belong in the Polly project.

TimHess avatar Jun 23 '23 15:06 TimHess