SteamKit icon indicating copy to clipboard operation
SteamKit copied to clipboard

CMClient.Send should throw when trying to send without a connection

Open xPaw opened this issue 3 years ago • 1 comments

What did you expect to happen?

Right now Send() just silently eats the send by doing a null check on connection, and catches io and socket exceptions.

Instead of that, what actually happened?

I think it should throw so any requests are not lost into ether (and I think async jobs will not resolve/fail until the next disconnect).

Which operating system are you running on?

No response

Which .NET Runtime are you running on?

.NET Core or .NET 5 or higher.

Version

6

Relevant log output

No response

Example Code

No response

Additional Information

No response

xPaw avatar May 19 '22 20:05 xPaw

Additional diagnostics available in #1102

azuisleet avatar May 20 '22 17:05 azuisleet