steamgriddb-manager icon indicating copy to clipboard operation
steamgriddb-manager copied to clipboard

since we're not linking anymore, update BPM pictures on manual pictur…

Open kongomongo opened this issue 5 years ago • 7 comments

…e selection. Also fixes BPM pictures on type 'other' (manually added to Steam)

kongomongo avatar Jan 16 '21 08:01 kongomongo

Hey could you send me a build with that fix? This has been nagging me for ages

lolcatplays avatar Jan 28 '21 19:01 lolcatplays

Hey could you send me a build with that fix? This has been nagging me for ages

@lolcatplays I adapt the code of @kongomongo and fix this issue in a new pull https://github.com/SteamGridDB/steamgriddb-manager/pull/135

I publish a built version with this fix and another if you want to install it The link is available in this issue : https://github.com/SteamGridDB/steamgriddb-manager/issues/130

SantaHey avatar Apr 05 '21 16:04 SantaHey

Thank you SO much

lolcatplays avatar Apr 05 '21 16:04 lolcatplays

Hey could you send me a build with that fix? This has been nagging me for ages

@lolcatplays I adapt the code of @kongomongo and fix this issue in a new pull #135

I publish a built version with this fix and another if you want to install it The link is available in this issue : #130

Strange, I never ran into that problem myself using master.

I use Steam/non-Steam, gog, etc... all without problems.

Can you show an example where the current master fails?

kongomongo avatar Apr 06 '21 16:04 kongomongo

Can you show an example where the current master fails?

I downloaded the master and added this code in Steam.js/getNonSteamGames() at line 151 log.info("\n---Name : "+ item.appName); log.info("appId from shortcuts.vdf: "+ item.appid); log.info("appId with bitwise unsigned 32bit: "+ (item.appid >>> 0)); log.info("Generated OldAppId : "+ this.generateAppId(exe, appName)); log.info("Generated NewAppID : "+ this.generateNewAppId(exe, appName));

Result : generateNewAppId() is the actual function used by SteamGridDB Manager and it's working only for games imported by SteamGridDB image

If I set my image with SteamGridDB it doesn't update in Steam and if I set manually it generates a file with appid from shortcuts.vdf that isn't corresponding to generateNewAppId() result

SantaHey avatar Apr 07 '21 21:04 SantaHey

You are correct, generateNewAppId fails for manually added non-steam games. The question remains: why?

kongomongo avatar May 01 '21 06:05 kongomongo

You are correct, generateNewAppId fails for manually added non-steam games. The question remains: why?

I think Steam generate a random id for every new non-steam game imported.

Example with the exact same executable, it generates each time a different. image

SantaHey avatar May 04 '21 00:05 SantaHey