steam-rom-manager icon indicating copy to clipboard operation
steam-rom-manager copied to clipboard
verified publisher icon SteamGridDB

Presets: Add ares systems

Open BlueInterlude opened this issue 1 year ago • 1 comments

  • Added the following ares systems:
    • Atari 2600, Bandai Wanderswan, Bandai Wanderswan Color, Benesse Pocket Challenge V2, Coleco ColecoVision, Microsoft MSX, Microsoft MSX 2, NEC PC Engine CD+TurboGrafx CD, NEC PC Engine SuperGrafx, NEC PC Engine+TurboGrafx 16, Nintendo Game Boy Advance, Nintendo Game Boy Color, Nintendo Game Boy, Nintendo NES, Sega 32X, Sega CD+Mega CD, Sega Game Gear, Sega Genesis+Mega Drive.Sega Master System, /Sega SG-1000, and Sinclair ZX Spectrum
  • Cosmetic:
    • Updated the GB family to add a space between "Game" and "Boy"
    • Updated the GC Steam category name to "GameCube" from "Gamecube"
    • Updated the GBA preset file to use "Game Boy Advance" for all presets (some were using "GameBoy", some were using "GameBoy Advance")

Minor issue, but there is some inconsistency with the Steam category names:

  • The GB family uses spelled out "Game Boy", "Game Boy Advance", and so on. The other systems use acronyms. I personally prefer the spelled out approach, but regardless of my opinion, I think it'd be good to have some sort of consistency using either format.
  • Regional differences are included for the NEC family and the Sega CD but not the NES and the SNES (Famicom and Super Famicom in Japan).

With the addition of the Bandai Wanderswan in this PR, there's also the issue with the SNK Neo Geo Pocket and SNK Neo Geo Pocket Color being combined into one preset. I split these for the Bandai, but ares supports the SNK NGP duo as well but has separate system names for both. Should the SNK NGP preset be split like the Bandai one?

BlueInterlude avatar Sep 06 '24 02:09 BlueInterlude

This is a very large set of changes, will need to review and possibly test it locally to make sure there's no errors that wind up breaking presets(I've done that myself before). Do not currently have time to do this.

kencinder avatar Sep 06 '24 14:09 kencinder

Due to file conflicts in this PR and reasons of time constraints, I added the ares presets to their own file https://github.com/SteamGridDB/steam-rom-manager/commit/1c2b0a93c73946c0390ed80daa36077694adc2c0

Thank you @BlueInterlude for the contribution

kencinder avatar Oct 02 '25 22:10 kencinder