decky-plugin-database icon indicating copy to clipboard operation
decky-plugin-database copied to clipboard

Add "Chrono-Deck" plugin

Open ynhhoJ opened this issue 1 year ago • 8 comments

ChronoDeck

Brings metadata for Emulated games to achieve a better native experience to the end user.

To do that I collected information about games for platforms: PS1, PS2, PSP, Nintendo3DS, NintendoDS, SNES and GameCube using Wikipedia.

Sheet with entire list of Games: https://docs.google.com/spreadsheets/d/1lF2zJN4S7Ktu8xaLgyymWm9I8kMW7ts2rR6cVj3ZmEA/edit

Checklist:

Developer Checklist

  • [x] I am the original author or an authorized maintainer of this plugin.
  • [x] have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • [x] I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • [x] I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Exists MetaDeck but it is not usable at the moment, and there is no ETA when plugin will start work again.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • [ ] Tested on SteamOS Stable/Beta Update Channel.

  • [ ] Tested on SteamOS Preview Update Channel.

ynhhoJ avatar Sep 05 '24 14:09 ynhhoJ

Please rebase your PR.

AAGaming00 avatar Sep 05 '24 15:09 AAGaming00

You are still updating all plugins in the repo...

TrainDoctor avatar Sep 05 '24 16:09 TrainDoctor

@TrainDoctor , yeah, sorry for that.

Now everything should be good.

ynhhoJ avatar Sep 05 '24 16:09 ynhhoJ

@TrainDoctor , yeah, sorry for that.

Now everything should be good.

Thanks, also in future if you want to update the PR with new changes please just do a normal commit unless absolutely necessary. The force pushes mean changes through development are much harder to track for anyone doing code review.

TrainDoctor avatar Sep 05 '24 16:09 TrainDoctor

@AAGaming00 will need you to do the review on this one as there is so much typescript etc that I don't feel properly equipped to review this one.

TrainDoctor avatar Sep 05 '24 16:09 TrainDoctor

Rebased branch to the latest changes from main branch of decky-plugin-database repository.

ynhhoJ avatar Sep 13 '24 22:09 ynhhoJ

@beebls , just pushed an update to minimize bandwidth consumption.

Can you review when you are free, please?

ynhhoJ avatar Sep 14 '24 10:09 ynhhoJ

@TrainDoctor , can you please checkout last modifications, when you are free?

Thanks!

P.S: I added some socials links to get better user feedback.

ynhhoJ avatar Sep 20 '24 20:09 ynhhoJ

New review needed :pray:

ynhhoJ avatar Oct 03 '24 17:10 ynhhoJ

@ynhhoJ please include the original plugin license from the plugin template at the bottom of your own license file and then we're good. That got missed in the first reviews and that's on me. Once that's done and a testing report is file we're good to merge to production.

TrainDoctor avatar Oct 13 '24 18:10 TrainDoctor

Latest build is up, apologies for the wait.

TrainDoctor avatar Oct 22 '24 18:10 TrainDoctor

Closing as untested. If you are able to locate a tester in future we will happily accept a re-submission.

TrainDoctor avatar Jan 12 '25 18:01 TrainDoctor

@ynhhoJ, if you are able to update this PR with a version of your plugin (please also make sure to bump your version by at least a patch to ensure no conflicts will occur in CI/CD etc) that you have verified with the latest stable versions of Loader then I can re-open this PR. (Please note the below text only applies if you are able to make the requested update, thanks for your understanding). The more plugins that can come back the higher chance you are able to see a tester for your plugin is my hope.

I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

TrainDoctor avatar Jan 14 '25 20:01 TrainDoctor

@TrainDoctor , hello!

Right now i'm focused more on SDH-PlayTime, when i'm done with it, I will return to ChronoDeck and will update it to latest version.

Just need some time to clarify with everything...

ynhhoJ avatar Jan 14 '25 20:01 ynhhoJ