decky-plugin-database icon indicating copy to clipboard operation
decky-plugin-database copied to clipboard

Add Change TTL

Open JuanJoseGonGi opened this issue 1 year ago • 5 comments

Change TTL

This plugin changes the default ipv4 and ipv6 TTL to the user specified one using sysctl commands.

Checklist:

Developer Checklist

  • [x] I am the original author or an authorized maintainer of this plugin.
  • [x] I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • [x] I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • [x] I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • [x] Tested on SteamOS Stable/Beta Update Channel.

  • [ ] Tested on SteamOS Preview Update Channel.

JuanJoseGonGi avatar Sep 01 '24 05:09 JuanJoseGonGi

why this plugin requires root to perform it's function which can be done without root access via KDE desktop.

AFAIK to change the TTL using sysctl you need root and in the tests I did it is so. I can't find in the KDE settings a related configuration. Can you please share what method could be used without root?

JuanJoseGonGi avatar Sep 05 '24 17:09 JuanJoseGonGi

why this plugin requires root to perform it's function which can be done without root access via KDE desktop.

AFAIK to change the TTL using sysctl you need root and in the tests I did it is so. I can't find in the KDE settings a related configuration. Can you please share what method could be used without root?

Apologies, I misunderstood what was meant by TTL and the access levels needed to modify it. What would be the purpose of modifying the TTL for Steam Deck users? (The plugin can go forward now but I'm just curious 😅)

TrainDoctor avatar Sep 05 '24 17:09 TrainDoctor

What would be the purpose of modifying the TTL for Steam Deck users

I personally use it to bypass mobile hotspot limits on data plans. I think it could be the main use case for deck

JuanJoseGonGi avatar Sep 05 '24 17:09 JuanJoseGonGi

Please also re-add a screenshot URL and a relevant image.

@TrainDoctor These 2 refer to the image field on the plugin.json?

JuanJoseGonGi avatar Sep 05 '24 22:09 JuanJoseGonGi

Please also re-add a screenshot URL and a relevant image.

@TrainDoctor These 2 refer to the image field on the plugin.json?

Yes, that's correct.

TrainDoctor avatar Sep 05 '24 22:09 TrainDoctor

Closing as untested. If you are able to locate a tester in future we will happily accept a re-submission.

TrainDoctor avatar Jan 12 '25 18:01 TrainDoctor

@JuanJoseGonGi, if you are able to update this PR with a version of your plugin (please also make sure to bump your version by at least a patch to ensure no conflicts will occur in CI/CD etc) that you have verified with the latest stable versions of Loader then I can re-open this PR. (Please note the below text only applies if you are able to make the requested update, thanks for your understanding). The more plugins that can come back the higher chance you are able to see a tester for your plugin is my hope.

I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

TrainDoctor avatar Jan 14 '25 20:01 TrainDoctor