decky-loader icon indicating copy to clipboard operation
decky-loader copied to clipboard

Fix settings import under windows

Open suchmememanyskill opened this issue 1 month ago • 1 comments

Please tick as appropriate:

  • [X] I have tested this code on a steam deck or on a PC
  • [X] My changes generate no new errors/warnings
  • [X] This is a bugfix/hotfix
  • [ ] This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: The settings import for some reason does not get picked up by pyinstaller running under windows, but does when running under linux. This PR adds an explicit import for the settings module to resolve this issue.

Effectively, plugins like tabmaster and steamgriddb (that use the settings api) will now work again under windows.

suchmememanyskill avatar Nov 29 '25 21:11 suchmememanyskill

Tested on Windows 25 H2, With Steam 1763795278 It works great !

This looks good to me, and hopefully maintainer approves soon.

BassemMohsen avatar Dec 04 '25 18:12 BassemMohsen

Why is not this merged yet? it passed all checks and no conflicts ? Do you have to assign reviewers, maybe? who's the maintainer of the repo?

BassemMohsen avatar Dec 20 '25 15:12 BassemMohsen