decky-loader icon indicating copy to clipboard operation
decky-loader copied to clipboard

fix(deps): update @decky/ui to version 4.10.1

Open shdwmtr opened this issue 6 months ago • 7 comments

Please tick as appropriate:

  • [x] I have tested this code on a steam deck or on a PC
  • [x] My changes generate no new errors/warnings
  • [x] This is a bugfix/hotfix
  • [ ] This is a new feature

Description

Update decky/ui to 4.10.1 which includes fixes for <Menu /> in the new Steam beta.

Parent PR: https://github.com/SteamDeckHomebrew/decky-frontend-lib/pull/119

shdwmtr avatar Jun 15 '25 20:06 shdwmtr

I'm assuming no other sub-projects on the org depend on @decky/ui but if they do I can bump them.

shdwmtr avatar Jun 15 '25 20:06 shdwmtr

Feel free to squash if you want to edit the commit note.

shdwmtr avatar Jun 15 '25 20:06 shdwmtr

you need to update pnpm lockfile

AAGaming00 avatar Jun 16 '25 14:06 AAGaming00

Ahh, didn't see you guys used --frozen-lockfile.

shdwmtr avatar Jun 16 '25 16:06 shdwmtr

@shdwmtr this PR is currently broken and will fail to show up in the menu after I installed it via testing page and then restarted. The type checker did fail so I suspect that may lead you to the core issue.

TrainDoctor avatar Jun 17 '25 01:06 TrainDoctor

The fix is easy, however the rooted issue was not caused by me. It was likely in versions of DFL after 4.8.3 and before 4.10.1. I could say with almost 100% confidence it was #92 with the addition of 4.10.0 as it never made its way into the loader.

The participants of #92 should take a look; if my hunch is right.

shdwmtr avatar Jun 17 '25 03:06 shdwmtr

Totally fair, and good catch. I will leave it to @AAGaming00 to review as soon as he has time.

TrainDoctor avatar Jun 17 '25 04:06 TrainDoctor

Alright, getting this merged.

TrainDoctor avatar Jun 28 '25 19:06 TrainDoctor