decky-loader icon indicating copy to clipboard operation
decky-loader copied to clipboard

[BUG] <title> 3.0.0 official version Game mode error

Open lzq960605 opened this issue 1 year ago • 19 comments

Please confirm

  • [X] I have searched existing issues
  • [ ] This issue is not a duplicate of an existing one
  • [X] I have checked the common issues section in the readme file
  • [X] I have attached logs to this bug report (failure to include logs will mean your issue may not be responded to).

Bug Report Description

7_5

Expected Behaviour

3.0.0 official version Game mode error ,Steam client is the latest beta version

SteamOS version

steam os 3.6.13

Selected Update Channel

Stable

Decky Loader Version

3.0.0

Plugin Info

deckylog.txt

Have you modified the read-only filesystem at any point?

No response

Backend Logs

deckylog.txt

Frontend Logs

cef_log.previous.txt cef_log.txt

lzq960605 avatar Sep 17 '24 02:09 lzq960605

@lzq960605 please give the latest pre-release a run and see if you continue to encounter this issue.

TrainDoctor avatar Sep 17 '24 02:09 TrainDoctor

@lzq960605 please give the latest pre-release a run and see if you continue to encounter this issue.

OK, I'll try.

lzq960605 avatar Sep 17 '24 02:09 lzq960605

@lzq960605 please give the latest pre-release a run and see if you continue to encounter this issue.

This issue has not yet been reproduced

lzq960605 avatar Sep 18 '24 14:09 lzq960605

I still get the error with Decky v3.0.1-pre3. It happens when deleting a screenshot. I think it might be related to Steam's new screenshot UI

mgnsk avatar Sep 19 '24 21:09 mgnsk

try again without decky, this is probably a steam bug

AAGaming00 avatar Sep 19 '24 22:09 AAGaming00

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

mgnsk avatar Sep 20 '24 14:09 mgnsk

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

If you can collect CEF logs at performing the actions with decky enabled and decky disabled and distinguish the two we can hopefully trace the issue. Otherwise we can't do much with this information as I've been unable to recreate the issue you've described.

TrainDoctor avatar Sep 20 '24 16:09 TrainDoctor

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

manged to recreate the issue myself

CEF logs: cef_log.txt cef_log.previous.txt

TrainDoctor avatar Sep 21 '24 02:09 TrainDoctor

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

It is true that this bug will appear when deleting the screenshots. It will also appear in decky3.0.1. I will try to reproduce it later.

lzq960605 avatar Sep 26 '24 01:09 lzq960605

cef_log.previous.txt cef_log.txt 7_5

Just delete the screenshot to reproduce the bug 100%

lzq960605 avatar Sep 26 '24 02:09 lzq960605

I have the same issue.This problem arises if the screenshot is deleted.

carrot117 avatar Oct 01 '24 13:10 carrot117

3.0.2 Screenshot_20241004_183442

lzq960605 avatar Oct 04 '24 10:10 lzq960605

https://github.com/user-attachments/assets/bae4d40b-2cfa-4d7f-a03e-46ed61718c50

Does anyone know how exactly is one supposed to reproduce this? I haven't been able to repro on v3.0.1 or v3.0.2-pre1.

eXhumer avatar Oct 04 '24 14:10 eXhumer

Decky-Recorder_2024-10-01_13-24-35.mp4 Does anyone know how exactly is one supposed to reproduce this? I haven't been able to repro on v3.0.1 or v3.0.2-pre1.

v3.0.2-pre2 fixed this problem, but the latest steam beta client has this problem again

lzq960605 avatar Oct 05 '24 10:10 lzq960605

I can reproduce this pretty easily as well with latest Beta Release and latest Decky Pre. Take a screenshot ingame, exit game normally, try to open the just snapped Screenshot from the Game Page directly. This will trigger that same error as well each time.

pchristod avatar Oct 10 '24 15:10 pchristod

I am no longer able to replicate this issue myself. If anyone can replicate it I will continue to keep this issue open.

TrainDoctor avatar Oct 13 '24 19:10 TrainDoctor

I am no longer able to replicate this issue myself. If anyone can replicate it I will continue to keep this issue open.

This problem still exists in v3.0.3-pre1 Screenshot_20241014_040257

lzq960605 avatar Oct 13 '24 20:10 lzq960605

Confirmed reproducible with 3.0.3-pre1.

Looking through the component stack trace in Steam Deck, the following two functions from Decky Loader seems to be attaching to the component before erroring.

20241013142124_1

eXhumer avatar Oct 13 '24 20:10 eXhumer

This is the function inside which it is failing.

        function F(e) {
            const {handle: t, controlsVisible: r, fnOnContentWidth: i} = e
              , a = (0,
            C.FD)(t)
              , [s,o] = (0,
            n.useState)(!1);
            (0,
            n.useEffect)(( () => o(!1)), [t]);
            const c = a.data
              , m = n.useCallback((e => {
                const t = e.target;
                i(t.clientWidth)
            }
            ), [i])
              , u = (0,
            y.wY)(m);
            if (a.isLoading)
                return n.createElement(g.O0, {
                    className: f.FocusedScreenshotSkeleton
                });
            if (a.isError || s)
                return n.createElement(le, {
                    className: f.FocusedScreenshotError
                }, n.createElement(A.Z, {
                    className: f.Message
                }, (0,
                l.we)("#ScreenshotUploader_FailedToLoadScreenshot")));
            const {strUrl: d} = c;
            return n.createElement(g.Kz, {
                direction: "column",
                space: "md",
                grow: !0
            }, n.createElement(A.Z, {
                className: f.FocusedScreenshotContainer
            }, n.createElement("div", {
                className: f.FocusedScreenshotImageContainer
            }, n.createElement("img", {
                ref: u,
                onError: () => o(!0),
                src: d,
                className: f.FocusedScreenshot
            })), n.createElement(G, {
                handle: t,
                screenshot: c,
                key: t,
                controlsVisible: r
            })))
        }

This is the destructing line that fails

            const {strUrl: d} = c;

eXhumer avatar Oct 13 '24 20:10 eXhumer

Decky-Recorder_2024-10-01_13-24-35.mp4 Does anyone know how exactly is one supposed to reproduce this? I haven't been able to repro on v3.0.1 or v3.0.2-pre1.

View the screenshot, then delete it in the viewing mode (or full screen mode?), that will trigger the issue.

Vegas7 avatar Nov 01 '24 11:11 Vegas7

decky 3.0.4 ,Steam stable version client,The problem still exists

lzq960605 avatar Nov 06 '24 07:11 lzq960605

7_2

lzq960605 avatar Nov 06 '24 07:11 lzq960605

Confirmed reproducible with 3.0.3-pre1.

Looking through the component stack trace in Steam Deck, the following two functions from Decky Loader seems to be attaching to the component before erroring.

20241013142124_1

those two don't matter, they'll always be there for all routes

AAGaming00 avatar Nov 06 '24 12:11 AAGaming00

Same as @lzq960605 mentioned, Decky Loader v3.0.4, SteamOS latest stable version, can be reproduced, disabling Decky Loader doesn't reproduce this issue.

https://streamable.com/1nv5i3

Tariomka avatar Nov 08 '24 18:11 Tariomka

Same as @lzq960605 mentioned, Decky Loader v3.0.4, SteamOS latest stable version, can be reproduced, disabling Decky Loader doesn't reproduce this issue.

https://streamable.com/1nv5i3

dead link, upload directly to GitHub instead

AAGaming00 avatar Nov 15 '24 13:11 AAGaming00

Same as @lzq960605 mentioned, Decky Loader v3.0.4, SteamOS latest stable version, can be reproduced, disabling Decky Loader doesn't reproduce this issue. https://streamable.com/1nv5i3

dead link, upload directly to GitHub instead

Sorry, had issues with attaching directly in Github. Here's the reproduction of this issue:

https://github.com/user-attachments/assets/8051787d-3a12-435b-b824-8921251e65fd

It's only reproducible when an image is opened, deleting from options menu works fine.

Tariomka avatar Nov 15 '24 18:11 Tariomka

This bug still exists in v3.0.5-pre1

lzq960605 avatar Dec 17 '24 06:12 lzq960605

This bug still exists in todays stable release v3.0.5

And as stated above, only occurs when deleting the screenshot after opening it, options menu works fine.

image

TehCrazyCat avatar Dec 18 '24 19:12 TehCrazyCat

Screenshot_20250103_183306

Still exists in v3.1.1-pre1

lzq960605 avatar Jan 03 '25 10:01 lzq960605