decky-loader icon indicating copy to clipboard operation
decky-loader copied to clipboard

Add Plugin.uninstall callback support

Open wheaney opened this issue 2 years ago • 7 comments

https://github.com/SteamDeckHomebrew/decky-loader/issues/536

Please tick as appropriate:

  • [x] I have tested this code on a steam deck or on a PC
  • [x] My changes generate no new errors/warnings
  • [x] This is a bugfix/hotfix
  • [ ] This is a new feature

Description

This fixes issue: #536

wheaney avatar Nov 01 '23 18:11 wheaney

Here is the PR for the plugin template update: https://github.com/SteamDeckHomebrew/decky-plugin-template/pull/34

wheaney avatar Nov 02 '23 16:11 wheaney

@TrainDoctor what's next for this?

wheaney avatar Nov 07 '23 23:11 wheaney

@TrainDoctor what's next for this?

Needs testing. @SteamDeckHomebrew/decky-testers please give this a shot and let me know if you encounter any issues.

TrainDoctor avatar Nov 08 '23 00:11 TrainDoctor

@wheaney apologies for the delay. I finally have time to give this a whirl tomorrow. If you can rebase it to latest main that'd make it much easier for me to test.

TrainDoctor avatar Dec 16 '23 01:12 TrainDoctor

I'm not sure what was going on with that first merge, but I think it's all sync'ed up now.

wheaney avatar Dec 16 '23 04:12 wheaney

I think this is a good addition - can you remove the empty file and rebase? Will do some testing the next days.

@wheaney once this change is made I can pretty easily merge this. Thanks.

TrainDoctor avatar Feb 09 '24 01:02 TrainDoctor

The commit history here was confusing me, so I just rebased, removed the empty file, and force pushed.

wheaney avatar Feb 26 '24 22:02 wheaney

Mergin, thanks for this @wheaney !

JohnnyCrazy avatar Mar 13 '24 22:03 JohnnyCrazy