FileDetectionRuleSets icon indicating copy to clipboard operation
FileDetectionRuleSets copied to clipboard

Updated Wwise detection to account for Godot plugin libraries and new Unity library

Open MonstoBusta opened this issue 1 year ago • 8 comments

SteamDB app page links to a few games using this

Runa & the Chaikurú Legacy: https://steamdb.info/app/2283470/ (depot showing the library in the files: https://steamdb.info/depot/2283472/)

Brief explanation of the change

Godot uses an unofficial but semi officially endorsed plugin to add Wwise to its games. However, the plugin's library file is different from the standard AkSoundEngine.dll. I have added the Godot version for both Godot 3.x and Godot 4.x to rules.ini and the test types folder. I did not account for WaapiGDNative.dll/so, but WWiseGDNative.dll/so should be enough. I don't know if this works so I would like someone with more knowledge of regex to see if what I typed works.

MonstoBusta avatar Sep 26 '24 21:09 MonstoBusta

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.Wwise

2012 apps still match.

These apps now match: (13) 1707220 1786010 1965810 2065530 2118940 2283470 2407540 2422440 2429640 2512930 3179920 3227630 3240600

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar Sep 26 '24 21:09 SteamDB-Tracker

I can confirm that these changed apps all use Wwise.

MonstoBusta avatar Sep 26 '24 21:09 MonstoBusta

I would also like to say that 2118940 is a Godot game (Godot 3.x), as is 3179920 (Godot 4.x), since to my knowledge only the Godot wwise plugins have the libraries named like that

MonstoBusta avatar Sep 26 '24 21:09 MonstoBusta

There's only 1 app that's using (based on what you said) Godot 4 & wwise that's not really enough to edit that rule to match these for now Let's only keep the godot 3 version

How many Godot 4.x games using Wwise must there be in order for those to be matched? The file for the 4.x plugin is from the same plugin as the 3.x extension, only updated. This plugin has also been put in a directory made by the Godot Foundation (https://github.com/godot-sdk-integrations).

MonstoBusta avatar Sep 26 '24 21:09 MonstoBusta

5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case

Lifeismana avatar Sep 26 '24 22:09 Lifeismana

5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case

So I presume that Chicken Fall Prologue is being counted as a separate game here rather than a demo (with Chicken Fall and Chicken Fall Prologue both having demos). Fine, I'll hope that more Godot 4 games use Wwise in the future

MonstoBusta avatar Sep 26 '24 22:09 MonstoBusta

There's no use in keeping the linux version when it doesn't help to detect more games

Lifeismana avatar Sep 30 '24 01:09 Lifeismana

apologies, I closed the pull request hoping that it wouldn't put my Unity commits into here. I cannot review without approving the changes btw

MonstoBusta avatar Sep 30 '24 02:09 MonstoBusta

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.Wwise

2230 apps still match.

These apps now match: (24) 1491410 1636040 1707220 1707990 1786010 1937930 1965810 2065530 2118940 2228830 2283470 2407540 2422440 3073000 3146830 3213990 3227630 3307570 3352190 3356650 3421130 3422780 3461770 3475870

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar Feb 11 '25 12:02 SteamDB-Tracker

merged in afe87f1485edbe95296172d4bc85fbbb94f49de0

Lifeismana avatar Feb 11 '25 13:02 Lifeismana