FileDetectionRuleSets icon indicating copy to clipboard operation
FileDetectionRuleSets copied to clipboard

Update curl

Open dfandrich opened this issue 1 year ago • 6 comments

The regex now matches any modern libcurl .so version, not just the range 7.56.0 to 7.65.3 that it matched before.

dfandrich avatar Jun 18 '24 21:06 dfandrich

Spot-checking the first five new matching apps show that the matches are expected. The first now matches libcurl.so.4.2.0 and the second libcurl.so.4.7.0. The remaining 3 (of those first 5) should already have been matching on UnityEngine.UnityCurlModule.dll under the old regex; it's unclear from the comment description if these are actually new matches or also matched previously.

The "no longer matching" app (1387510) is puzzling. No file includes "curl" in the name so not matching is expected and correct, but it's implied that it matched before, under the old regex. I don't see how that could have been the case.

dfandrich avatar Jun 18 '24 21:06 dfandrich

yeah, there's something odd with the bot, some of the apps should already be detected as using curl without this change

Lifeismana avatar Jun 18 '24 21:06 Lifeismana

it's most likely a problem elsewhere, these apps don't have all their depots with filenames decrypted (visible to us), that probably where the problem lies

Lifeismana avatar Jun 18 '24 21:06 Lifeismana

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.cURL

22731 apps still match.

These apps now match: (8) 683890 1628350 1733380 2308170 2767220 2951520 2980310 3039110

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar Jun 19 '24 13:06 SteamDB-Tracker

this looks better although the 2 relevant apps for this pr are 683892 & 1628351 i think there's a simpler way to detect them

Lifeismana avatar Jun 19 '24 13:06 Lifeismana

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.cURL

24823 apps still match.

These apps no longer match: (1) 2416790

These apps now match: (70) 41800 65300 683890 1513570 1628350 1695000 1989410 2117370 2279180 2332850 2343170 2479840 2502990 2568700 2569430 2580310 2581510 2608510 2615440 2615880 2622400 2659850 2709710 2745110 2754750 2776840 2779010 2805880 2815690 2820120 2822670 2879590 2902090 2921870 2942620 2946490 2955070 2955820 2960120 2967500 3011200 3027850 3029480 3029830 3031590 3031700 3033360 3033960 3034870 3036410 3050820 3065390 3097630 3101720 3107840 3113640 3124390 3127440 3136270 3136300 3145980 3148940 3150240 3156860 3156990 3163450 3178850 3184470 3190940 3195030

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar Sep 01 '24 04:09 SteamDB-Tracker

I checked the first 5 and last 5 of the changed apps in the previous comment and they all look correct.

dfandrich avatar Sep 01 '24 05:09 dfandrich