FileDetectionRuleSets icon indicating copy to clipboard operation
FileDetectionRuleSets copied to clipboard

Update XAudio 2 SDK

Open MichaelHinrichs opened this issue 10 months ago • 6 comments

SteamDB app page links to a few games using this

Asteroids

Brief explanation of the change

Find XAudio2_7_64.dll.

MichaelHinrichs avatar Apr 11 '24 18:04 MichaelHinrichs

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.XAudio2

10923 apps still match.

These apps no longer match: (1) 2650370

These apps now match: (15) 1306770 2006450 2058260 2116120 2238690 2423300 2555290 2761580 2803790 2839320 2854030 2884020 2888740 2904920 2906500

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar Apr 11 '24 18:04 SteamDB-Tracker

The unmatch isn't my fault. All that's left of that app are the stock Visual C and DirectX depos.

MichaelHinrichs avatar Apr 11 '24 19:04 MichaelHinrichs

Asteroids is the only new match. All the rest were matched to XAudio 2 already. There are no false positives, so I see no reason to reject this PR.

MichaelHinrichs avatar Apr 11 '24 19:04 MichaelHinrichs

Doing this change for only one app is not worth it

Lifeismana avatar Apr 11 '24 19:04 Lifeismana

Well, it doesn't make it WORSE, now does it?

MichaelHinrichs avatar Apr 11 '24 20:04 MichaelHinrichs

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.XAudio2

11063 apps still match.

These apps no longer match: (3) 1590010 2633070 2650370

These apps now match: (33) 908360 1499130 1607140 1668580 1718540 1817800 1847120 1873140 1881440 2058260 2068540 2124300 2217180 2223620 2238690 2248330 2312980 2409000 2418480 2423300 2435470 2574470 2602300 2706230 2761580 2768010 2807290 2837640 2854030 2873050 2878180 2888160 2901040

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar Apr 25 '24 03:04 SteamDB-Tracker

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.XAudio2

11395 apps still match.

These apps now match: (7) 2058260 2504480 2597880 2916710 2924850 2963110 2976390

Please confirm that all these changed apps are correct.

SteamDB-Tracker avatar May 19 '24 01:05 SteamDB-Tracker

your modification doesn't detect anything \d should not be used, it matches other digit characters, [0-9] should be used instead making regex modifications only for one app is not worth the decreased readability

Lifeismana avatar May 19 '24 01:05 Lifeismana