Update Pico8

[MichaelHinrichs]

SteamDB app page links to a few games using this

https://steamdb.info/app/1494910/

Brief explanation of the change

The PICO-8 game pemsa uses files with a "p8" file type.

[xPaw]

This only matches the literal file .p8.

[gibbed]

Missing a description as well.

[MichaelHinrichs]

This only matches the literal file .p8.

Then why does it work in all of these files? https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.ChromeEngine.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.GameMaker.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.RPGMaker.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.RenPy.txt

[MichaelHinrichs]

Missing a description as well.

PICO-8 already has a description. Is there something else i should have described? https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/descriptions/Engine.Pico8.md

[gibbed]

PICO-8 already has a description. Is there something else i should have described? https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/descriptions/Engine.Pico8.md

Sorry, that's my bad-- I incorrectly assumed you were adding a new entry for Pico8 entirely.

[Lifeismana]

This only matches the literal file .p8.

Then why does it work in all of these files? https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.ChromeEngine.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.GameMaker.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.RPGMaker.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.RenPy.txt

Did you take a look at these engines rules ?

(?:^|/).p8$ =>.p8 \.rpack$ => .rpack \.gm(?:spr|bck)$ => .gmbck | .gmspr \.(?:rgssad|rvproj2|rgss3a|rgss2a)$ => .rgss2a | .rgss3a | .rgssad |.rvproj2 \.rpyb$ => .rpyb

[xPaw]

(?:^|/) matches start of string or after a slash. It should be \.p8$

[MichaelHinrichs]

This only matches the literal file .p8.

Then why does it work in all of these files? https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.ChromeEngine.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.GameMaker.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.RPGMaker.txt https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/tests/types/Engine.RenPy.txt

Did you take a look at these engines rules ?

(?:^|/).p8$ =>.p8 \.rpack$ => .rpack \.gm(?:spr|bck)$ => .gmbck | .gmspr \.(?:rgssad|rvproj2|rgss3a|rgss2a)$ => .rgss2a | .rgss3a | .rgssad |.rvproj2 \.rpyb$ => .rpyb

Where the heck does it say any of that?

[Lifeismana]

You might want to read (or reread) https://github.com/SteamDatabase/FileDetectionRuleSets/blob/main/CONTRIBUTING.md

(?:^|/).p8$ from rules.ini => .p8 from the test file

[MichaelHinrichs]

Is that better?

[xPaw]

This is the only game that uses this extension, how come?

[MichaelHinrichs]

I don't know, does it matter? It's a pico-8 game that's not detected as pico-8! Add it to the list.

[SteamDB-Tracker]

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: Engine.Pico8

These apps now match: (29) 642020 917140 1275070 1282710 1296550 1354460 1448220 1448720 1451860 1472810 1494910 1519610 1749310 1857970 1953060 2216120 2318570 2425010 2447920 2448440 2552900 2587030 2658990 2675390 2675400 2684450 2707300 2737990 2766260

Please confirm that all these changed apps are correct.

[MichaelHinrichs]

False positive. https://steamdb.info/depot/1857971/