klipper-backup icon indicating copy to clipboard operation
klipper-backup copied to clipboard

Beware of inode notify!

Open bsafh opened this issue 3 months ago • 7 comments

Code of Conduct

  • [x] I promise that i have used markdown syntax to make the code more readable which helps to fix the problem and that I have tested the --fix command mentioned above without success.

What happened

Well, the backup itself works fine.

But the inode notify gives me trouble: it blocks Klipper from communicating with the MCU of the printer after some 30 minutes, Klipper crashes with "mcu: timer too close".

This on a OrangePi Zero 3 wirh an eMMC instead of an microSDcard, drivinf an BTT Octopus Pro 1.1 board in CAN bridge mode.

What did you expect to happen

Klipper not crashing.

How to reproduce

Install klipper-filewatch-service

sudo systemctl daemon-reload
sudo systemctl enable klipper-backup-filewatch.service
sudo systemctl start klipper-backup-filewatch.service

Start any print with more than 3ü minutes duration.

Result: "mcu: timer too close", Klipper hard crash.

reverse:

sudo systemctl stop klipper-backup-filewatch.service
sudo systemctl disable klipper-backup-filewatch.service
sudo systemctl daemon-reload

Everything is back to normal, no Klipper crashes.

Debug

Does not matter

Additional information

No response

bsafh avatar Oct 09 '25 20:10 bsafh

I am not able to reproduce this. Are you running the latest version of inotify? There is a new release after 3 years. If no: Please update and test. If yes: Please go back to 3.22.6.0.

You also mentioned, that you are using a CAN setup. This article is about the 'Timer Too Close' issue which is triggered by high cpu load. Maybe inotify triggers this issue on your specific setup?

I get the same issue a couple of years ago. I could solve this with this crontab entry @reboot sed -i 's\TRSYNC_TIMEOUT = 0.025\TRSYNC_TIMEOUT = 0.05\g' ~/klipper/klippy/mcu.py. Maybe this is working for you?

Staubgeborener avatar Oct 11 '25 16:10 Staubgeborener

I guess that it is the latest inotify, as I pulled it from github with standard settings.

I'll try changing the timer as well, but earliest next weekend.

bsafh avatar Oct 12 '25 06:10 bsafh

Yeah, just try both and please give some feedback. If it really is the inotify version, then we will force an installation of the penultimate version. In any case, I will update the docs accordingly after I hear back from you.

Staubgeborener avatar Oct 12 '25 09:10 Staubgeborener

This issue is stale because it has been open for 14 days with no activity.

github-actions[bot] avatar Oct 27 '25 02:10 github-actions[bot]

@the3dfox Can you confirm that the problem is solved when you have disabled the filewatch service with sudo systemctl stop klipper-backup-filewatch.service?

Staubgeborener avatar Nov 07 '25 14:11 Staubgeborener

If yes, can you please test this new filewatch.sh code. Just like that:

sudo rm ~/klipper-backup/utils/filewatch.sh
sudo nano ~/klipper-backup/utils/filewatch.sh #copy/paste new code here
chmod +x ~/klipper-backup/utils/filewatch.sh
sudo systemctl restart klipper-backup-filewatch.service

(Same for @bsafh )

Staubgeborener avatar Nov 07 '25 14:11 Staubgeborener

@bsafh @the3dfox

I just released a new version v1.3.5 that might solve the problem. You can test it and give me some feedback. I'll put the stale tag back here for now.

Staubgeborener avatar Nov 13 '25 19:11 Staubgeborener

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Nov 28 '25 02:11 github-actions[bot]