start-os icon indicating copy to clipboard operation
start-os copied to clipboard

SSL Manager is not Transaction Safe

Open ProofOfKeags opened this issue 4 years ago • 3 comments

Currently the SSL Manager does not make changes to the root and intermediate certificates in SQL transactions and it probably ought to.

ProofOfKeags avatar Oct 18 '21 16:10 ProofOfKeags

I don't plan to work on this until we figure out the cause of #593

ProofOfKeags avatar Oct 18 '21 16:10 ProofOfKeags

@dr-bonez can you give any input on what you think the severity of this issue is? For me I think the issue is more theoretical than an actual issue since the only transactional component is making sure the root cert and the int cert are saved atomically.

ProofOfKeags avatar Oct 18 '21 18:10 ProofOfKeags

as long as the function is idempotent wrt partial completion I don't care. But transactions are good to use and should be trivial to implement

dr-bonez avatar Oct 18 '21 20:10 dr-bonez