start-os icon indicating copy to clipboard operation
start-os copied to clipboard

[bug] Sideloaded service configuration fails if pointers previously existed

Open elvece opened this issue 1 year ago • 2 comments

After sideloading a service, attempting to configure it if the config had union pointers in 0351 fails with the following error:

Screenshot 2024-10-15 at 4 48 30 PM

The patch payload:

Screenshot 2024-10-15 at 4 48 22 PM

This error does not occur if the same service@version is installed from the marketplace. Example:

  • sideload this btcpay version
  • attempt to save config
  • see error
  • uninstall
  • install same version of btcpay from the alpha marketplace
  • attempt to configure
  • configuration saves successfully

elvece avatar Oct 15 '24 21:10 elvece

Some more context here, as there are multiple possible bugs:

  1. installing from alpha and sideloading are producing different behavior.
  2. when side loaded, the observed behavior might have nothing to do with pointers, might just be unions in general. Need to test another service with unions to confirm.
  3. when installed from alpha, running the action "works", meaning no error is produced, but neither does it result in the expected dependnecies being created. Upon running the action, BTCPay should have dependencies on both Bitcoin an LND/CLN, but neither are created.

MattDHill avatar Oct 16 '24 14:10 MattDHill

This happens 100% of the time when you have a fresh OS image with no services installed and sideload or install btcpay from alpha. If you uninstall btcpay and sideload/ install from alpha it again, the error persists.

If you install bitcoin, configure it, and then configure btcpay, the error is not produced.

so perhaps its only if the first service you try to save is a service that previously had a config union with pointers.

elvece avatar Oct 16 '24 16:10 elvece

@elvece is this still a thing?

MattDHill avatar Dec 19 '24 17:12 MattDHill

@elvece is this still a thing?

Will confirm

elvece avatar Dec 19 '24 19:12 elvece

This happens 100% of the time when you have a fresh OS image with no services installed and sideload or install btcpay from alpha. If you uninstall btcpay and sideload/ install from alpha it again, the error persists.

If you install bitcoin, configure it, and then configure btcpay, the error is not produced.

so perhaps its only if the first service you try to save is a service that previously had a config union with pointers.

Confirmed this bug still exists on alpha10 when testing this scenario @dr-bonez

elvece avatar Jan 16 '25 02:01 elvece

I think this is fixed by #2832

dr-bonez avatar Feb 20 '25 19:02 dr-bonez