start-os icon indicating copy to clipboard operation
start-os copied to clipboard

[bug]: no way to exit out of config set errors, refresh required

Open chrisguida opened this issue 1 year ago • 4 comments

Steps to reproduce:

  1. Click save on invalid config
  2. See error below:
Screen Shot 2022-07-22 at 12 05 02 PM
  1. Notice that there's no way to exit out of the error, no "x" button, ESC key does nothing. Only refreshing the page makes the error go away.

Suggested solutions:

Error boxes should have some way of clearing them, such as the ESC key or an "x" button in the top left or right corner

chrisguida avatar Jul 22 '22 17:07 chrisguida

Hmmm I can't explain or reproduce this. No matter what that error is, there should always be a button in the toast. Can you try again and gather more info from the console and network tab?

MattDHill avatar Jul 22 '22 18:07 MattDHill

This is somewhat of an edge case. Right now it reliably happens when migrating a version of CLN where the config has clboss as a boolean to a version where clboss is a union of objects. Strangely, the error only occurs when i try to change from a boolean value to a union of enabled, which contains sub-keys. The error does not occur when I choose the disabled variant, which is an empty object with no subkeys. For some reason the OS is fine with this.

Console does not contain any errors, network tab has this result:

Screen Shot 2022-07-25 at 2 40 17 PM

chrisguida avatar Jul 25 '22 19:07 chrisguida

OK so there appears to be two different issues here. (1) the issue of a close button missing from the error toast and (2) you not being able to change the CLBOSS from a boolean to a union.

I think #2 is expected and probably should not be made to work. You should create a new key.

MattDHill avatar Jul 25 '22 20:07 MattDHill

(2) is not the issue, I've talked to blu-j and discovered the problem. But yes, (1) needs to be fixed.

chrisguida avatar Jul 26 '22 02:07 chrisguida

Should be solved by new config module

MattDHill avatar May 31 '23 15:05 MattDHill