Dustin Deus
Dustin Deus
My plan would be: ### Round 1 * [Delvedor suggestion](https://github.com/mcollina/avvio/pull/56#issuecomment-377683090) * It's minor change because the error of `close(err)` could never be true but is present in the parameters. ###...
> Why remove the ready call? For me, it's wrong that `close` handle more than it should. If you want to bootstrap the app call `start` or enable autostart period....
> I strongly suggest you to moderate your tone. Don't be so pedantic! This is a technical discussion and I just make my point clear. > While I can agree...
> It is not a matter of mixing up, in theory a user should not call close before calling ready, it is useless and we all agree on this. *...
* Throw error when a user try to call `close` before `ready` (or before plugin queue `drains`) * Document that `close` can only be called after `ready` * Don't call...
> Note that avvio does not anything about prefixes, those are fastify thing. Good note. This must be enriched in a different way. I leave it open so anybody can...
Did you really test it? I still can reproduce it in both examples.
I found it out. You really need to call `toJSON` on all objects `Request`, `Collection`, ... Invalid ```js collectionDefinition.item?.push({ name: op.Name, request: new Request(request), }); ``` valid ```js collectionDefinition.item?.push({ name:...
Hi @mariosant, I will open some issues in near future! Thank you!
Hi, I just wanted to open the same issue. The lib looks really promising. I don't want to be forced to use a specific CSS-in-JS solution. I only want to...