apollo-datasource-http icon indicating copy to clipboard operation
apollo-datasource-http copied to clipboard

Proposal of tweaks around global and local cache configuration

Open kdybicz opened this issue 3 years ago • 2 comments

  • Making sure global cache configuration is taken into consideration for all datasource methods
  • Making sure method-specific cache configuration is overriding global configuration, if present
  • Adding related tests
  • Adding VSC configuration folder to .gitignore

kdybicz avatar Jul 01 '22 09:07 kdybicz

@StarpTech I'm happy to talk through the changes I've made and the motivation, I also have following changes queued up, ie. for optional maxTtlIfError and I'm thinking on improving performance and bandwidth used while caching with maxTtlIfError

kdybicz avatar Jul 09 '22 08:07 kdybicz

Hi @kdybicz sorry for the late response. Your change will give request options precedence over global defaults. This is natural and the current behavior was more of a bug.

StarpTech avatar Aug 27 '22 15:08 StarpTech