Xumin

Results 212 comments of Xumin

Since the issue is tracked at a different repo I'm closing the ticket. Please feel free to reopen it if you have any further concerns.

Thanks for reporting this. This is a known issue of the gRPC-gateway. Lua has an implementation limitation in that we cannot tell an empty array from an empty table(object); also,...

@bungle Could review this again?

I agree with @bungle 's worries. I think we can live with this bug till 4.0. We can choose to emit warnings only. This change only affects protocol checking. Only...

Converting to draft as we changed the solution.

> same as [#10723 (comment)](https://github.com/Kong/kong/pull/10723#issuecomment-1521073370), Please try to add some tests to this. And also the changelog.

We force-pushed to the master recently so the history is messed up. Could you rebase the PR towards the master so it can be reviewable?

I think this is how you create the plugin: ```bash curl -X POST http://localhost:8001/services/SERVICE_NAME|SERVICE_ID/plugins \ --data "name=ip-restriction" \ --data "config.allow=54.13.21.1" \ --data "config.allow=143.1.0.0/24" ``` refer: https://docs.konghq.com/hub/kong-inc/ip-restriction/configuration/examples/

> > I think this is how you create the plugin: > > ```shell > > curl -X POST http://localhost:8001/services/SERVICE_NAME|SERVICE_ID/plugins \ > > --data "name=ip-restriction" \ > > --data "config.allow=54.13.21.1"...

@rwa-siteimprove I tried to locate the positions you mentioned and it seems the file has already changed. Could you specify what version of Kong you were using? The error message...