starlight icon indicating copy to clipboard operation
starlight copied to clipboard

feat: add finally return support

Open jameslahm opened this issue 3 years ago • 6 comments

Fix #7

jameslahm avatar Jun 30 '21 06:06 jameslahm

Oh wow! That's nice work! But seems like there's some regression as now half of previously passing test262 tests do not pass:

Results:
Total tests: 78695
Passed tests: 6187
Ignored tests: 24233
Failed tests: 48275 (panics: 1497)
Conformance: 7.86%

dev branch:

Results:
Total tests: 78695
Passed tests: 12579
Ignored tests: 24233
Failed tests: 41883 (panics: 1244)
Conformance: 15.98%

EDIT: You can see how much tests pass in Actions

playXE avatar Jun 30 '21 08:06 playXE

Hi, I encountered a segment fault error when I run sl examples/hello-world.js without .startupshot. I feel like there has some problem in add_conservative in gc.rs. Do you have this problem?

jameslahm avatar Jun 30 '21 10:06 jameslahm

It seems that I found it. I will push and try to run test262.

jameslahm avatar Jun 30 '21 11:06 jameslahm

Hi, I encountered a segment fault error when I run sl examples/hello-world.js without .startupshot. I feel like there has some problem in add_conservative in gc.rs. Do you have this problem?

Unfortunately, I will not have access to PC for one or two days so Idk where the problem is. I actually tested the new GC when I was merging it and hello-world was working fine. Can you please check that you run the latest dev branch GC?

playXE avatar Jun 30 '21 11:06 playXE

The problem should be here. And I have added the index check. It works fine now. https://github.com/Starlight-JS/starlight/blob/df79b323af25be4132589cf16a3a6537203d9adf/crates/starlight/src/gc/space_bitmap.rs#L84-L93 EDIT: I have checked that I am on the latest dev branch

jameslahm avatar Jun 30 '21 12:06 jameslahm

And I continue to look at the problem of regression testing 🤣

jameslahm avatar Jun 30 '21 12:06 jameslahm