starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Refactor] Change the field type of service id to String

Open TszKitLo40 opened this issue 1 year ago • 1 comments

What type of PR is this:

  • [ ] bug
  • [ ] feature
  • [ ] enhancement
  • [x] refactor
  • [ ] others

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Change the field type of service id to String

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

TszKitLo40 avatar Aug 12 '22 08:08 TszKitLo40

Looks like test case should be changed or improved to reflect serviceId type change.

kevincai avatar Aug 12 '22 09:08 kevincai

Looks like test case should be changed or improved to reflect serviceId type change.

I have changed the test case.

TszKitLo40 avatar Aug 12 '22 10:08 TszKitLo40

[FE PR Coverage Check]

:heart_eyes: pass : 4 / 5 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/lake/StarOSAgent.java 4 5 80.00% [172]

wanpengfei-git avatar Aug 17 '22 11:08 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Aug 18 '22 03:08 wanpengfei-git

run starrocks_admit_test

TszKitLo40 avatar Aug 18 '22 04:08 TszKitLo40